Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLRC XPack Protocol clean up: Licence, Misc #34469

Merged

Conversation

@vladimirdolzhenko
Copy link
Contributor

commented Oct 15, 2018

Move parts related to XPack Licence and Misc from protocol to client

Relates #34451

Vladimir Dolzhenko
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Oct 15, 2018

@vladimirdolzhenko vladimirdolzhenko referenced this pull request Oct 15, 2018
6 of 7 tasks complete
Vladimir Dolzhenko
}

public void testPutLicense() throws Exception {
// TODO

This comment has been minimized.

Copy link
@vladimirdolzhenko

vladimirdolzhenko Oct 15, 2018

Author Contributor

we need start trial ( #33406 ) as a roll back here licence revert here, seems to be same discussion as we can have for #33606 and #33406

@hub-cap hub-cap self-requested a review Oct 15, 2018

@hub-cap
Copy link
Contributor

left a comment

I think we can split this into 2 PRs, one for the refactor, and one for the protocol-test stuff. I dont think they are related, either. <3 for the cleanup!!!


public class XPackUsageRequest extends MasterNodeRequest<XPackUsageRequest> {

This comment has been minimized.

Copy link
@hub-cap

hub-cap Oct 16, 2018

Contributor

lolwut... thanks for nothing, git.

@@ -58,7 +55,7 @@
});

static {
PARSER.declareBoolean(constructorArg(), new ParseField("acknowledged"));

This comment has been minimized.

Copy link
@hub-cap

hub-cap Oct 16, 2018

Contributor

i actually dont mind having these defined here if we dont use them anywhere else.

@vladimirdolzhenko vladimirdolzhenko requested a review from hub-cap Oct 18, 2018

@vladimirdolzhenko vladimirdolzhenko removed the WIP label Oct 18, 2018

@vladimirdolzhenko

This comment has been minimized.

Copy link
Contributor Author

commented Oct 18, 2018

@hub-cap I've raised another PR for cross xpack-hlrc tests (actually it's PoC) #34547 . Could you pls have another look into this ?

Vladimir Dolzhenko added 2 commits Oct 19, 2018
@vladimirdolzhenko

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2018

run gradle build tests please

@hub-cap
Copy link
Contributor

left a comment

Looks good now, ty for splitting.

@vladimirdolzhenko vladimirdolzhenko merged commit 423d085 into elastic:master Oct 19, 2018

4 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
@vladimirdolzhenko

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2018

thanks @hub-cap for the review

@vladimirdolzhenko vladimirdolzhenko deleted the vladimirdolzhenko:hlrc_xprotocol_cleanup_1 branch Oct 19, 2018

vladimirdolzhenko added a commit that referenced this pull request Oct 19, 2018
kcm added a commit that referenced this pull request Oct 30, 2018

@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.