Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Fix NPE thrown if HAVING filter evals to null #35108

Merged
merged 1 commit into from Oct 31, 2018

Conversation

@matriv
Copy link
Contributor

commented Oct 30, 2018

Surround script with nullSafeFilter also for AggFilter translation.
Fixed query translation tests to properly set onAggs.

Fixes: #35107

SQL: Fix NPE thrown if HAVING filter evals to null
Surround script with `nullSafeFilter` also for `AggFilter` translation.
Fixed query translation tests to properly set `onAggs`.

Fixes: #35107
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Oct 30, 2018

Pinging @elastic/es-search-aggs

@costin
costin approved these changes Oct 30, 2018
Copy link
Member

left a comment

LGTM

@matriv matriv merged commit bf6f521 into elastic:master Oct 31, 2018

4 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@matriv matriv deleted the matriv:mt/fix-35107 branch Oct 31, 2018

matriv added a commit that referenced this pull request Oct 31, 2018
SQL: Fix NPE thrown if HAVING filter evals to null (#35108)
Surround script with `nullSafeFilter` also for `AggFilter` translation.
Fixed query translation tests to properly set `onAggs`.

Fixes: #35107
@matriv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

Backported to 6.x with 9eb5769

matriv added a commit that referenced this pull request Oct 31, 2018
SQL: Fix NPE thrown if HAVING filter evals to null (#35108)
Surround script with `nullSafeFilter` also for `AggFilter` translation.
Fixed query translation tests to properly set `onAggs`.

Fixes: #35107
@matriv

This comment has been minimized.

Copy link
Contributor Author

commented Oct 31, 2018

Backported to 6.5 with de3d0e6

matriv added a commit to matriv/elasticsearch that referenced this pull request Oct 31, 2018
SQL: Fix null handling for IN => painless script
Include `null` literals when generating the painless script for `IN` expressions.
Previously, they were skipped, because of an issue that had been fixed with elastic#35108.

Fixes: elastic#35122

@colings86 colings86 added v6.5.0 and removed v6.5.1 labels Nov 2, 2018

matriv added a commit that referenced this pull request Nov 2, 2018
SQL: Fix null handling for IN => painless script (#35124)
Include `null` literals when generating the painless script for `IN` expressions.
Previously, they were skipped, because of an issue that had been fixed with #35108.

Fixes: #35122
matriv added a commit that referenced this pull request Nov 2, 2018
SQL: Fix null handling for IN => painless script (#35124)
Include `null` literals when generating the painless script for `IN` expressions.
Previously, they were skipped, because of an issue that had been fixed with #35108.

Fixes: #35122
matriv added a commit that referenced this pull request Nov 2, 2018
SQL: Fix null handling for IN => painless script (#35124)
Include `null` literals when generating the painless script for `IN` expressions.
Previously, they were skipped, because of an issue that had been fixed with #35108.

Fixes: #35122

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.