Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract RunOnce into a dedicated class #35489

Merged
merged 2 commits into from Nov 14, 2018

Conversation

Projects
None yet
5 participants
@tlrx
Copy link
Member

commented Nov 13, 2018

This pull request extracts the static inner class RunOnce from WorkerBulkByScrollTaskState so that it can be reused at other places. It also adds tests.

@elasticmachine

This comment has been minimized.

Copy link

commented Nov 13, 2018

@jasontedor
Copy link
Member

left a comment

Looks good. Thanks for the tests!

@tlrx tlrx force-pushed the tlrx:relocate-add-once branch from df46faa to 016984a Nov 14, 2018

tlrx added some commits Nov 13, 2018

@tlrx tlrx force-pushed the tlrx:relocate-add-once branch from 016984a to f8719e3 Nov 14, 2018

@tlrx tlrx merged commit c8c8ce2 into elastic:master Nov 14, 2018

3 checks passed

elasticsearch-ci Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@tlrx tlrx deleted the tlrx:relocate-add-once branch Nov 14, 2018

@tlrx

This comment has been minimized.

Copy link
Member Author

commented Nov 14, 2018

Thanks @jasontedor

tlrx added a commit that referenced this pull request Nov 14, 2018

Extract RunOnce into a dedicated class (#35489)
This commit extracts the static inner class RunOnce from 
WorkerBulkByScrollTaskState so that it can be reused at 
other places.

@tlrx tlrx added the v6.6.0 label Nov 14, 2018

tlrx added a commit that referenced this pull request Nov 15, 2018

Use RunOnce when appropriate (#35553)
This pull request replaces some blocks of code that must be run once 
and that are currently based on AtomicBoolean by the convient RunOnce 
class added in #35489.

tlrx added a commit that referenced this pull request Nov 15, 2018

Use RunOnce when appropriate (#35553)
This pull request replaces some blocks of code that must be run once
and that are currently based on AtomicBoolean by the convient RunOnce
class added in #35489.
@bleskes

This comment has been minimized.

Copy link
Member

commented Nov 15, 2018

Thanks @tlrx !

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.