Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate types in update APIs #36225

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@markharwood
Copy link
Contributor

commented Dec 4, 2018

Assumes we use _doc in the /index/_doc/id/_update url to follow pattern in CRUD family of URL verbs (get/index/delete/update). Use of a custom doctype in place of _doc causes a deprecation warning.

  • Deprecated typed constructor on UpdateRequest used by HLRC
  • Updated docs for HLRC but not for REST api - REST examples already use _doc which now represents a verb/api rather than a doc type.
  • Changed CRUDIT to use typeless UpdateRequest constructor and added test using deprecated typed API
  • Added RestUpdateActionTests to check for issuance of deprecation warnings.
Assumption in this PR is new REST endpoint is `/index/_doc/id/_update…
…` i.e. we have _doc in the url to represent CRUD family of URL verbs (get/index/delete/update), not a doctype.

Deprecated typed constructor on UpdateRequest used by HLRC
Updated docs for HLRC but not for REST api - REST examples already use _doc which now represents an verb/api rather than a doc type.
Changed CRUDIT to use typeless UpdateRequest constructor and added test using deprecated API
Added RestUpdateActionTests
@elasticmachine

This comment has been minimized.

Copy link

commented Dec 4, 2018

markharwood added some commits Dec 4, 2018

Avoid deprecation warnings relating to use of update api failing test…
…. Ideally we could add an assertWarnings() call in here to say what we expect as deprecation messages but ESRestTestCase base class does not parse any deprecation headers (I think)

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.