New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal and anonymous authentication types #36331

Merged
merged 4 commits into from Dec 13, 2018

Conversation

Projects
None yet
3 participants
@jaymode
Member

jaymode commented Dec 6, 2018

This change builds upon the work done in #35970 and adds appropriate
types for anonymous and internal authentication to the
AuthenticationType enum.

Add internal and anonymous authentication types
This change builds upon the work done in #35970 and adds appropriate
types for anonymous and internal authentication to the
`AuthenticationType` enum.
@elasticmachine

This comment has been minimized.

elasticmachine commented Dec 6, 2018

@tvernum

Looks good, other than the striking absence of any tests.

jaymode added some commits Dec 11, 2018

@jaymode

This comment has been minimized.

Member

jaymode commented Dec 11, 2018

other than the striking absence of any tests.

👍 I pushed a commit that adds asserts in existing tests

@jaymode jaymode requested a review from tvernum Dec 12, 2018

@tvernum

👍

@jaymode jaymode merged commit 7989b95 into elastic:security_api_keys Dec 13, 2018

7 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci-1 Build finished.
Details
elasticsearch-ci-2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@jaymode jaymode deleted the jaymode:api_key_auth_types branch Dec 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment