Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change missing authn message to not mention tokens #36750

Merged
merged 4 commits into from Dec 28, 2018

Conversation

Projects
None yet
4 participants
@tvernum
Copy link
Contributor

commented Dec 18, 2018

The phrase "missing authentication token" is historic and is based
around the use of "AuthenticationToken" objects inside the Realm code.

However, now that we have a TokenService and token API, this message
would sometimes lead people in the wrong direction and they would try
and generate a "token" for authentication purposes when they would
typically just need a username:password Basic Auth header.

This change replace the word "token" with "credentials".

tvernum added some commits Dec 17, 2018

Change missing authn message to not mention tokens
The phrase "missing authentication token" is historic and is based
around the use of "AuthenticationToken" objects inside the Realm code.

However, now that we have a TokenService and token API, this message
would sometimes lead people in the wrong direction and they would try
and generate a "token" for authentication purposes when they would
typically just need a username:password Basic Auth header.

This change replace the word "token" with "credentials".
@elasticmachine

This comment has been minimized.

Copy link

commented Dec 18, 2018

@tvernum

This comment has been minimized.

Copy link
Contributor Author

commented Dec 18, 2018

Given that we are checking for the old message in Rest and Packaging tests, I think it's prudent to only make this change for 7.0

We don't guarantee BWC in such error messages in minors, but it doesn't seem like it's worth backporting it to 6.7 when 7.0 is so close.

@jaymode
Copy link
Member

left a comment

LGTM

dimitris-athanasiou added a commit that referenced this pull request Dec 19, 2018

@tvernum

This comment has been minimized.

Copy link
Contributor Author

commented Dec 28, 2018

[ant:junit4] ERROR: JVM J0 ended with an exception: Forked process returned with error code: 137. Very likely a JVM crash.  See process stderr at: /var/lib/jenkins/workspace/elastic+elasticsearch+pull-request-1/server/build/testrun/integTest/temp/junit4-J0-20181228_020810_9308219151954334259194.syserr

@elasticmachine -- run gradle build tests 1

@tvernum tvernum merged commit e16fd4e into elastic:master Dec 28, 2018

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci-1 Build finished.
Details
elasticsearch-ci-2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Dec 28, 2018

Change missing authn message to not mention tokens (elastic#36750)
The phrase "missing authentication token" is historic and is based
around the use of "AuthenticationToken" objects inside the Realm code.

However, now that we have a TokenService and token API, this message
would sometimes lead people in the wrong direction and they would try
and generate a "token" for authentication purposes when they would
typically just need a username:password Basic Auth header.

This change replaces the word "token" with "credentials".

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.