Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Close Index API] Mark shard copy as stale if needed during shard verification #36755

Conversation

Projects
None yet
4 participants
@tlrx
Copy link
Member

commented Dec 18, 2018

Note: this pull request will be merged in the close-index-api-refactoring branch

This pull request modifies the TransportVerifyShardBeforeCloseAction so that it marks unavailable shards as stale.

@elasticmachine

This comment has been minimized.

Copy link

commented Dec 18, 2018

@tlrx tlrx requested a review from ywelsch Dec 18, 2018

@ywelsch
Copy link
Contributor

left a comment

Once we solve the flush problem it would be good to have a test that closes an index under complex situations (e.g. network partitions) and checks that we can always allocate a "closed" or "frozen" primary.

@tlrx

This comment has been minimized.

Copy link
Member Author

commented Dec 18, 2018

@elasticmachine run the default distro tests

@tlrx tlrx merged commit 103c4d4 into elastic:close-index-api-refactoring Dec 18, 2018

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci-1 Build finished.
Details
elasticsearch-ci-2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@tlrx tlrx deleted the tlrx:close-index-api-markShardCopyAsStaleIfNeeded branch Dec 18, 2018

tlrx added a commit that referenced this pull request Jan 14, 2019

Backport the Close Index API refactoring to 6.x (#37359)
This commit backports to 6.x of the Close Index API refactoring.

It cherry-picks the following commits from master:
3ca885e [Close Index API] Add TransportShardCloseAction for pre-closing verifications (#36249)
8e5dd20 [Close Index API] Refactor MetaDataIndexStateService (#36354)
7372529 [Tests] Reduce randomization in CloseWhileRelocatingShardsIT (#36694)
103c4d4 [Close Index API] Mark unavailable shard copy as stale during verification (#36755)
1959388 [Close Index API] Propagate tasks ids between Freeze, Close and Verify(#36630)
e149b08 [Close Index API] Add unique UUID to ClusterBlock (#36775)
dc371ef [Tests] Fix ReopenWhileClosingIT with correct min num shards

The following two commits were needed to adapt the change to 6.x:
ef6ae69 [Close Index API] Adapt MetaDataIndexStateServiceTests after merge
21b7653 [Tests] Adapt CloseIndexIT tests for 6.x

Related to #33888

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.