Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ccr to xpack usage infrastructure #37256

Merged
merged 13 commits into from Jan 30, 2019

Conversation

Projects
None yet
5 participants
@martijnvg
Copy link
Member

commented Jan 9, 2019

Closes #37221

@elasticmachine

This comment has been minimized.

Copy link

commented Jan 9, 2019

martijnvg added some commits Jan 9, 2019

martijnvg added some commits Jan 21, 2019

@ycombinator

This comment has been minimized.

Copy link
Contributor

commented Jan 22, 2019

Hi folks, we have a PR in Kibana that's waiting on the functionality in this PR: elastic/kibana#28840. Any chance we could get this reviewed soon? Thanks!

@dnhatn

dnhatn approved these changes Jan 28, 2019

Copy link
Contributor

left a comment

I left some minor nits but LGTM.

martijnvg added some commits Jan 29, 2019

replace `last_follower_index_creation_date` with `time_since_last_ind…
…ex_followed`,

because I think that is more valuable to return.
@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

@dnhatn I made a slight modification to this PR. Instead of returning last_follower_index_creation_date, I change the ccr feature set to return time_since_last_index_followed. I think this is more valuable to return than a timestamp.

@dnhatn

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

@martijnvg Yes, the new stat is more valuable 💯. I am fine with time_since_last_index_followed but maybe just call it last_follow_time?

@martijnvg

This comment has been minimized.

Copy link
Member Author

commented Jan 29, 2019

@dnhatn I've renamed the field to last_follow_time_in_millis. Also last_follow_time_in_millis will not be reported if there are no follower indices (the returned value wouldn't make sense).

@dnhatn

dnhatn approved these changes Jan 29, 2019

Copy link
Contributor

left a comment

Thanks @martijnvg.

martijnvg added some commits Jan 29, 2019

@martijnvg martijnvg merged commit f51bc00 into elastic:master Jan 30, 2019

8 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

martijnvg added a commit that referenced this pull request Jan 30, 2019

Added ccr to xpack usage infrastructure (#37256)
* Added ccr to xpack usage infrastructure

Closes #37221

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 30, 2019

Merge branch 'master' into retention-lease-stats
* master: (29 commits)
  Fix limit on retaining sequence number (elastic#37992)
  Docs test fix, wait for shards active.
  Revert "Revert "Documented default values for index follow request parameters. (elastic#37917)""
  Revert "Documented default values for index follow request parameters. (elastic#37917)"
  Ensure date parsing BWC compatibility (elastic#37929)
  SQL: Skip the nested and object field types in case of an ODBC request (elastic#37948)
  Use mappings to format doc-value fields by default. (elastic#30831)
  Give precedence to index creation when mixing typed templates with typeless index creation and vice-versa. (elastic#37871)
  Add classifier to tar.gz in docker compose (elastic#38011)
  Documented default values for index follow request parameters. (elastic#37917)
  Fix fetch source option in expand search phase (elastic#37908)
  Restore a noop _all metadata field for 6x indices (elastic#37808)
  Added ccr to xpack usage infrastructure (elastic#37256)
  Fix exit code for Security CLI tools  (elastic#37956)
  Streamline S3 Repository- and Client-Settings (elastic#37393)
  Add version 6.6.1 (elastic#37975)
  Ensure task metadata not null in follow test (elastic#37993)
  Docs fix - missing callout
  Types removal - deprecate include_type_name with index templates (elastic#37484)
  Handle completion suggestion without contexts
  ...

henningandersen added a commit to henningandersen/elasticsearch that referenced this pull request Jan 30, 2019

Added ccr to xpack usage infrastructure (elastic#37256)
* Added ccr to xpack usage infrastructure

Closes elastic#37221

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.