Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate index audit output type #37301

Closed

Conversation

Projects
None yet
5 participants
@albertzaharovits
Copy link
Contributor

commented Jan 10, 2019

This PR deprecates the index audit output.
In general, the problem with it is that event indexing can be slower than the rate with which audit events are generated, especially during the daily rollovers or the rolling cluster upgrades. In this situation audit events will be lost which is a terrible failure case for an audit system.

I will follow-up with the removal PR for 7.0 .

Relates #29881

CC @ycombinator

@elasticmachine

This comment has been minimized.

Copy link

commented Jan 10, 2019

@ycombinator

This comment has been minimized.

Copy link
Contributor

commented Jan 10, 2019

The beats work to handle this deprecation is close to being done: elastic/beats#8852

@jaymode
Copy link
Member

left a comment

LGTM

@jaymode
Copy link
Member

left a comment

Sorry I was too quick with the LGTM. This should also add a check in NodeDeprecationChecks

@albertzaharovits

This comment has been minimized.

Copy link
Contributor Author

commented Jan 13, 2019

Ah, right.
I was planning to add this in the follow-up 7.0 PR that actually removes the output type because the deprecation check will be admonishing that the output type has been removed. But the 7.0 PR does not touch the 6.x branch, yet the check has to sit in 6.x. I will add the check.

@albertzaharovits albertzaharovits changed the base branch from master to 6.x Jan 20, 2019

@albertzaharovits albertzaharovits changed the base branch from 6.x to master Jan 20, 2019

@albertzaharovits

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

@jaymode I went for a new PR to add the NodeDeprecationChecks. The files for these are only stubs in master so I guess the idiomatic way to add these is a 6.x PR which I have opened here #37671 . I will follow with a master only PR to remove the output altogether and add the /migration/migrate_7_0/settings.asciidoc notice.

@albertzaharovits albertzaharovits deleted the albertzaharovits:deprecate_index_audit branch Jan 22, 2019

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.