Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make finalize step of recovery source non-blocking #37388

merged 5 commits into from Jan 14, 2019


None yet
4 participants
Copy link

commented Jan 12, 2019

Relates #37291


This comment has been minimized.

Copy link

commented Jan 12, 2019


s1monw approved these changes Jan 14, 2019

Copy link

left a comment

left some suggestions but LGTM otherwise. Much simpler to review now, thanks for the extra interation


This comment has been minimized.

Copy link
Contributor Author

commented Jan 14, 2019

Thanks @s1monw.

@dnhatn dnhatn merged commit 397f315 into elastic:master Jan 14, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
elasticsearch-ci-1 Build finished.
elasticsearch-ci-2 Build finished.
elasticsearch-ci/default-distro Build finished.
elasticsearch-ci/docbldesx Build finished.
elasticsearch-ci/oss-distro-docs Build finished.
elasticsearch-ci/packaging-sample Build finished.

@dnhatn dnhatn deleted the dnhatn:finalize-step-non-blocking branch Jan 14, 2019

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 15, 2019

Merge branch 'master' into sync-retention-leases
* master: (28 commits)
  Introduce retention lease serialization (elastic#37447)
  Update Delete Watch to allow unknown fields (elastic#37435)
  Make finalize step of recovery source non-blocking (elastic#37388)
  Update the default for include_type_name to false. (elastic#37285)
  Security: remove SSL settings fallback (elastic#36846)
  Adding mapping for hostname field (elastic#37288)
  Relax assertSameDocIdsOnShards assertion
  Reduce recovery time with compress or secure transport (elastic#36981)
  Implement ccr file restore (elastic#37130)
  Fix Eclipse specific compilation issue (elastic#37419)
  Performance fix. Reduce deprecation calls for the same bulk request (elastic#37415)
  [ML] Use String rep of Version in map for serialisation (elastic#37416)
  Cleanup Deadcode in Rest Tests (elastic#37418)
  Mute IndexShardRetentionLeaseTests.testCommit elastic#37420
  unmuted test
  Remove unused index store in directory service
  Improve CloseWhileRelocatingShardsIT (elastic#37348)
  Fix ClusterBlock serialization and Close Index API logic after backport to 6.x (elastic#37360)
  Update the scroll example in the docs (elastic#37394)
  Update analysis.asciidoc (elastic#37404)

dnhatn added a commit that referenced this pull request Jan 15, 2019

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.