Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate xpack.watcher.history.cleaner_service.enabled #37782

Merged
merged 2 commits into from Jan 24, 2019

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

commented Jan 23, 2019

This deprecates the xpack.watcher.history.cleaner_service.enabled setting,
since all newly created .watch-history indices in 7.0 will use ILM to manage
their retention.

In 8.0 the setting itself and cleanup actions will be removed.

Resolves #32041

Deprecate xpack.watcher.history.cleaner_service.enabled
This deprecates the `xpack.watcher.history.cleaner_service.enabled` setting,
since all newly created `.watch-history` indices in 7.0 will use ILM to manage
their retention.

In 8.0 the setting itself and cleanup actions will be removed.

Resolves #32041
@elasticmachine

This comment has been minimized.

Copy link

commented Jan 23, 2019

@gwbrown

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2019

Could you also add a deprecation check for this setting?

@dakrone

This comment has been minimized.

Copy link
Member Author

commented Jan 24, 2019

@gwbrown not sure what you mean exactly? Marking the setting as deprecated I believe causes logging for deprecation when the setting is set

@gwbrown

This comment has been minimized.

Copy link
Contributor

commented Jan 24, 2019

@dakrone Sorry, I meant in the Deprecations API, similar to #36185 - I'd like to make this automatically catch deprecated settings, but until then it's a manual process.

@gwbrown
Copy link
Contributor

left a comment

LGTM - After discussion with @dakrone we've decided to not add a deprecation check to this PR as it will likely be addressed by other planned improvements to the Deprecations API.

@dakrone dakrone merged commit 0f3c542 into elastic:master Jan 24, 2019

8 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@dakrone dakrone deleted the dakrone:deprecate-watch-history-cleaner branch Feb 4, 2019

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.