Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Datafeed deprecation checks #37932

Merged
merged 6 commits into from Jan 30, 2019

Conversation

Projects
None yet
4 participants
@davidkyle
Copy link
Member

commented Jan 28, 2019

Deprecation checks for ml datafeed query and aggregations

davidkyle added some commits Jan 25, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Jan 28, 2019

@davidkyle davidkyle removed the WIP label Jan 28, 2019

Add BWC logic to wire read/write methods
This actually highlights a bug in 6.0-6.6: the deprecation
endpoint would not necessarily work in a mixed version
cluster containing 5.6.5 plus one of these versions.  But
what's done is done and nobody has complained so far...

@droberts195 droberts195 added the v7.0.0 label Jan 29, 2019

@droberts195

This comment has been minimized.

Copy link
Contributor

commented Jan 29, 2019

The deprecation info endpoint existed throughout the lifetime of 6.x, and if we'd done this for the ML bits too then it would have simplified the BWC wire transport checks. Therefore I will forward port this change to master so we don't have the same problem in 7.last.

In the forward port to master some of the tests will become no-ops, as initially there won't be any deprecated search syntax in 7.0. I will put TODOs in these tests to add some deprecated search syntax once something has been deprecated for 8.0.

@droberts195 droberts195 merged commit 58a76c2 into elastic:6.x Jan 30, 2019

7 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Jan 30, 2019

[ML] Datafeed deprecation checks (elastic#37932)
Deprecation checks for the ML datafeed
query and aggregations.

@droberts195 droberts195 removed the v7.0.0 label Jan 30, 2019

@droberts195

This comment has been minimized.

Copy link
Contributor

commented Jan 30, 2019

The master branch forward port of this is in #38026.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.