Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add basic REST test for geohash_grid #37996

Merged
merged 4 commits into from Feb 5, 2019

Conversation

Projects
None yet
4 participants
@talevy
Copy link
Contributor

commented Jan 29, 2019

this PR is a part of the general initiative to get more REST coverage in aggregations: #26220

@talevy talevy requested a review from polyfractal Jan 29, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Jan 29, 2019

@polyfractal polyfractal referenced this pull request Jan 29, 2019

Open

Comprehensive aggregation REST tests #26220

10 of 47 tasks complete
@colings86

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

Please could you merge this after #37611 to avoid us having to do another iteration on that large PR?

@colings86

This comment has been minimized.

Copy link
Member

commented Jan 30, 2019

#37611 is now merged

@talevy

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

awesome! last thing I would have wanted was to make that PR more of a headache
than it looks like it already was! thanks Colin

@talevy talevy added the v7.0.0 label Feb 5, 2019

@polyfractal
Copy link
Member

left a comment

👍 thanks!

If you're feeling extra motivated we could add a test for illegal precision values, to verify the exception

@talevy talevy merged commit ae47c02 into elastic:master Feb 5, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@talevy talevy deleted the talevy:rest-geohash branch Feb 5, 2019

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 5, 2019

Merge branch 'master' into retention-leases-recovery
* master: (23 commits)
  Lift retention lease expiration to index shard (elastic#38380)
  Make Ccr recovery file chunk size configurable (elastic#38370)
  Prevent CCR recovery from missing documents (elastic#38237)
  re-enables awaitsfixed datemath tests (elastic#38376)
  Types removal fix FullClusterRestartIT warnings (elastic#38445)
  Make sure to reject mappings with type _doc when include_type_name is false. (elastic#38270)
  Updates the grok patterns to be consistent with logstash (elastic#27181)
  Ignore type-removal warnings in XPackRestTestHelper (elastic#38431)
  testHlrcFromXContent() should respect assertToXContentEquivalence() (elastic#38232)
  add basic REST test for geohash_grid (elastic#37996)
  Remove DiscoveryPlugin#getDiscoveryTypes (elastic#38414)
  Fix the clock resolution to millis in GetWatchResponseTests (elastic#38405)
  Throw AssertionError when no master (elastic#38432)
  `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API (elastic#38411)
  Enable CronEvalToolTest.testEnsureDateIsShownInRootLocale (elastic#38394)
  Fix failures in BulkProcessorIT#testGlobalParametersAndBulkProcessor. (elastic#38129)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Mute testReadRequestsReturnLatestMappingVersion (elastic#38438)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38423)
  Update Rollup Caps to allow unknown fields (elastic#38339)
  ...

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.