Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ILM setPriority corrections for a 0 value #38001

Merged
merged 4 commits into from Jan 30, 2019

Conversation

Projects
None yet
5 participants
@jakelandis
Copy link
Contributor

commented Jan 30, 2019

This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes #37652

ILM setPriority corrections for a 0 value
This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes #37652
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jan 30, 2019

@jakelandis

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

@elasticmachine run elasticsearch-ci/1

jakelandis added some commits Jan 30, 2019

Revert "fix transform/search"
This reverts commit fb63663.
(wrong branch)
@dakrone
Copy link
Member

left a comment

LGTM, left one comment about the doc change

Show resolved Hide resolved x-pack/docs/en/watcher/transform/search.asciidoc Outdated
@jakelandis

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

@dakrone thanks for the review ! will merge on green.

@jakelandis jakelandis merged commit dad41c2 into elastic:master Jan 30, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit to dnhatn/elasticsearch that referenced this pull request Jan 31, 2019

Merge remote-tracking branch 'elastic/master' into pr/37940
* elastic/master:
  ILM setPriority corrections for a 0 value (elastic#38001)
  Temporarily disable BWC for retention lease stats (elastic#38049)
  Skip Shrink when numberOfShards not changed (elastic#37953)
  Add dispatching to `HandledTransportAction` (elastic#38050)
  Update httpclient for JDK 11 TLS engine (elastic#37994)
  Reduce flaxiness of ccr recovery timeouts test (elastic#38035)
  Fix ILM status to allow unknown fields (elastic#38043)
  Fix ILM Lifecycle Policy to allow unknown fields (elastic#38041)
  Update verify repository to allow unknown fields (elastic#37619)
  [ML] Datafeed deprecation checks (elastic#38026)
  Deprecate minimum_master_nodes (elastic#37868)
  Remove types from watcher docs (elastic#38002)
  Add test coverage for Painless general casting of boolean and Boolean (elastic#37780)
  Fixed test bug, lastFollowTime is null if there are no follower indices.
  Add ECS schema for user-agent ingest processor (elastic#37727) (elastic#37984)
  Extract TransportRequestDeduplication from ShardStateAction (elastic#37870)

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Jan 31, 2019

Merge remote-tracking branch 'elastic/master' into replication-tracke…
…r-primary-term

* elastic/master:
  Mute failing date index name processor test
  Reenable BWC testing after retention lease stats (elastic#38062)
  Move watcher to use seq# and primary term for concurrency control (elastic#37977)
  ILM setPriority corrections for a 0 value (elastic#38001)
  Temporarily disable BWC for retention lease stats (elastic#38049)
  Skip Shrink when numberOfShards not changed (elastic#37953)
  Add dispatching to `HandledTransportAction` (elastic#38050)
  Update httpclient for JDK 11 TLS engine (elastic#37994)
  Reduce flaxiness of ccr recovery timeouts test (elastic#38035)
  Fix ILM status to allow unknown fields (elastic#38043)
  Fix ILM Lifecycle Policy to allow unknown fields (elastic#38041)
  Update verify repository to allow unknown fields (elastic#37619)
  [ML] Datafeed deprecation checks (elastic#38026)
  Deprecate minimum_master_nodes (elastic#37868)

jakelandis added a commit to jakelandis/elasticsearch that referenced this pull request Jan 31, 2019

ILM setPriority corrections for a 0 value (elastic#38001)
This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes elastic#37652

jakelandis added a commit that referenced this pull request Feb 1, 2019

ILM setPriority corrections for a 0 value (#38001) (#38136)
This commit fixes the test case that ensures only a priority
less then 0 is used with testNonPositivePriority. This also
allows the HLRC to support a value of 0.

Closes #37652

@colings86 colings86 added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.