Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Restore date aggregation performance in UTC case #38221
The nightly benchmarks showed a sharp decrease in aggregation performance for
This commit uses the same calculation as joda time, which requires no
Benchmark comparison (on my notebook):
final results comparing against the joda implementations (all benchmarks taken on my osx notebook, so take with a grain of salt)
I also added a duelling test class that runs against the old implementation to see if there are any inconsistencies. I ran this class a couple of million times on my linux without failure.
rally run of
same run against this branch
danielmitterdorfer left a comment
I left a few comments. The macrobenchmark results look promising indeed. I did not check the parts that you took from Joda time but I wonder whether we need to attribute this more clearly.
DaveCTurner left a comment
I left mostly suggestions about the names of things. I think we should have more thorough tests for the copied code, particularly around the boundaries (e.g. month boundaries ±1ms) and with negative numbers.