Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation check for No Master Block setting #38383

Merged
merged 5 commits into from Feb 5, 2019

Conversation

Projects
None yet
3 participants
@gwbrown
Copy link
Contributor

commented Feb 5, 2019

discovery.zen.no_master_block is deprecated in favor of
cluster.no_master_block in 7.0, but is a dynamic setting so we need
both node- and cluster-level checks for it.

Relates to #38350 and #36024

Deprecation check for No Master Block setting
`discovery.zen.no_master_block` is deprecated in favor of
`cluster.no_master_block` in 7.0, but is a dynamic setting so we need
both node- and cluster-level checks for it.
@elasticmachine

This comment has been minimized.

Copy link

commented Feb 5, 2019

@gwbrown gwbrown referenced this pull request Feb 5, 2019

Closed

Update Deprecation Info API for 7.0 breaking changes #36024

26 of 26 tasks complete
@DaveCTurner
Copy link
Contributor

left a comment

I would interpret the message here as indicating that I can update my settings in 6.x, but that's not the case. I think we should be clearer that we will quietly ignore discovery.zen.no_master_block in 7.0, and the action that the user should take is to clear any value set for discovery.zen.no_master_block pre-upgrade and to set cluster.no_master_block post-upgrade.

gwbrown added some commits Feb 5, 2019

@gwbrown

This comment has been minimized.

Copy link
Contributor Author

commented Feb 5, 2019

Thanks for the review @DaveCTurner, I've addressed your comments - what do you think of the new message?

@DaveCTurner
Copy link
Contributor

left a comment

LGTM

@gwbrown gwbrown merged commit 5512574 into elastic:6.x Feb 5, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 6, 2019

Merge branch '6.x' into retention-leases-recovery-6.x
* 6.x: (25 commits)
  Backport of types removal for Put/Get index templates (elastic#38465)
  Add support for API keys to access Elasticsearch (elastic#38291) (elastic#38399)
  Deprecate support for internal versioning for concurrency control (elastic#38451)
  Deprecate types in rollover index API (elastic#38389) (elastic#38458)
  Add typless client side GetIndexRequest calls and response class (elastic#38422)
  [ML] Report index unavailable instead of waiting for lazy node (elastic#38444)
  await fix CurtIT#testIndex until elastic#38451 is merged (elastic#38466)
  Update ilm-api.asciidoc, point to REMOVE policy (elastic#38235) (elastic#38464)
  SQL: Fix esType for DATETIME/DATE and INTERVALS (elastic#38179)
  Clean up duplicate follow config parameter code (elastic#37688) (elastic#38443)
  Deprecation check for No Master Block setting (elastic#38383)
  Bubble-up exceptions from scheduler (elastic#38441)
  Lift retention lease expiration to index shard (elastic#38391)
  Deprecate maxRetryTimeout in RestClient and increase default value (elastic#38425)
  Update Rollup Caps to allow unknown fields (elastic#38446)
  Backport of elastic#38411: `if_seq_no` and `if_primary_term` parameters aren't wired correctly in REST Client's CRUD API
  Support unknown fields in ingest pipeline map configuration (elastic#38429)
  SQL: Implement CURRENT_DATE (elastic#38175)
  Backport changes to the release notes script. (elastic#38346)
  Fix ILM explain response to allow unknown fields (elastic#38363)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.