Join GitHub today
Update IndexTemplateMetaData to allow unknown fields #38448
Update IndexTemplateMetaData to use ObjectParser
Also a test was added that randomly generates a response that an ES node would returns and
referenced this pull request
Feb 5, 2019
I don't think this can go back to 6.7 , since if I read this correctly... it also removes support for the deprecated "template" field, which Logstash (and possibly others) still uses on 6.x.
EDIT: this is client only code, so we don't need to add to deprecation info API
jakelandis left a comment
LGTM for 7.x only
However, I would encourage a test that explicitly tests that "template" is no longer supported.
I just realized this is only for the client code (not server side), so no need to add to breaking changes for server. I am OK with the client being more aggressive here then the server w/r/t to support for the deprecated field. (A test here would help to communicate that too).
The logic that with the
Yes, I will open an issue for this.