Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Prevent grouping over grouping functions #38649

Merged
merged 2 commits into from Feb 9, 2019

Conversation

Projects
None yet
5 participants
@costin
Copy link
Member

commented Feb 8, 2019

Improve verifier to disallow grouping over grouping functions (e.g.
HISTOGRAM over HISTOGRAM).

Close #38308

SQL: Prevent grouping over grouping functions
Improve verifier to disallow grouping over grouping functions (e.g.
HISTOGRAM over HISTOGRAM).

Close #38308
@elasticmachine

This comment has been minimized.

Copy link

commented Feb 8, 2019

@costin costin added the >bug label Feb 8, 2019

@matriv

matriv approved these changes Feb 8, 2019

Copy link
Contributor

left a comment

LGTM

@matriv

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2019

Should id be v7.0.0 instead of v7.0.0-beta1?

private static void checkGroupingFunctionTarget(GroupingFunction f, Set<Failure> localFailures) {
f.field().forEachDown(e -> {
if (e instanceof GroupingFunction) {
localFailures.add(fail(f.field(), "Cannot embed a grouping function within another grouping", Expressions.name(f)));

This comment has been minimized.

Copy link
@astefan

astefan Feb 8, 2019

Contributor

... within another grouping FUNCTION?

This comment has been minimized.

Copy link
@costin

costin Feb 9, 2019

Author Member

Rephrased the message to be a bit more clearer without repeating the words.

@astefan

astefan approved these changes Feb 8, 2019

Copy link
Contributor

left a comment

LGTM. Left one minor comment.

@costin

This comment has been minimized.

Copy link
Member Author

commented Feb 9, 2019

Should id be v7.0.0 instead of v7.0.0-beta1?

You're right - I'll change the labels.

@costin costin added v7.0.0 and removed v7.0.0-beta1 labels Feb 9, 2019

@costin costin merged commit 4e9b1cf into elastic:master Feb 9, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@costin costin deleted the costin:fix-38308 branch Feb 9, 2019

costin added a commit that referenced this pull request Feb 9, 2019

SQL: Prevent grouping over grouping functions (#38649)
Improve verifier to disallow grouping over grouping functions (e.g.
HISTOGRAM over HISTOGRAM).

Close #38308

(cherry picked from commit 4e9b1cf)

costin added a commit that referenced this pull request Feb 9, 2019

SQL: Prevent grouping over grouping functions (#38649)
Improve verifier to disallow grouping over grouping functions (e.g.
HISTOGRAM over HISTOGRAM).

Close #38308

(cherry picked from commit 4e9b1cf)
(cherry picked from commit 794ee4f)

costin added a commit that referenced this pull request Feb 9, 2019

SQL: Prevent grouping over grouping functions (#38649)
Improve verifier to disallow grouping over grouping functions (e.g.
HISTOGRAM over HISTOGRAM).

Close #38308

(cherry picked from commit 4e9b1cf)
(cherry picked from commit 794ee4f)

jasontedor added a commit to liketic/elasticsearch that referenced this pull request Feb 10, 2019

Merge branch 'master' into pr/28895
* master: (1159 commits)
  Fix timezone fallback in ingest processor (elastic#38407)
  Avoid polluting download stats on builds (elastic#38660)
  SQL: Prevent grouping over grouping functions (elastic#38649)
  SQL: Relax StackOverflow circuit breaker for constants (elastic#38572)
  [DOCS] Fixes broken migration links (elastic#38655)
  Drop support for the low-level REST client on JDK 7 (elastic#38540)
  [DOCS] Adds placeholders for v8 highlights, breaking changes, release notes (elastic#38641)
  fix dissect doc "ip" --> "clientip" (elastic#38545)
  Concurrent file chunk fetching for CCR restore (elastic#38495)
  make DateMathIndexExpressionsIntegrationIT more resilient (elastic#38473)
  SQL: Replace joda with java time (elastic#38437)
  Add fuzziness example (elastic#37194) (elastic#38648)
  Mute AnalysisModuleTests#testStandardFilterBWC (elastic#38636)
  add geotile_grid ref to asciidoc (elastic#38632)
  Enable Dockerfile from artifacts.elastic.co (elastic#38552)
  Mute FollowerFailOverIT testFailOverOnFollower (elastic#38634)
  Account for a possible rolled over file while reading the audit log file (elastic#34909)
  Mute failure in InternalEngineTests (elastic#38622)
  Fix Issue with Concurrent Snapshot Init + Delete (elastic#38518)
  Refactor ZonedDateTime.now in millis resolution (elastic#38577)
  ...

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 11, 2019

Merge branch 'master' into retention-lease-ccr
* master:
  Fix timezone fallback in ingest processor (elastic#38407)
  Avoid polluting download stats on builds (elastic#38660)
  SQL: Prevent grouping over grouping functions (elastic#38649)
  SQL: Relax StackOverflow circuit breaker for constants (elastic#38572)
  [DOCS] Fixes broken migration links (elastic#38655)
  Drop support for the low-level REST client on JDK 7 (elastic#38540)
  [DOCS] Adds placeholders for v8 highlights, breaking changes, release notes (elastic#38641)
  fix dissect doc "ip" --> "clientip" (elastic#38545)
  Concurrent file chunk fetching for CCR restore (elastic#38495)
  make DateMathIndexExpressionsIntegrationIT more resilient (elastic#38473)
  SQL: Replace joda with java time (elastic#38437)
  Add fuzziness example (elastic#37194) (elastic#38648)

@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 12, 2019

dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Feb 12, 2019

SQL: Prevent grouping over grouping functions (elastic#38649)
Improve verifier to disallow grouping over grouping functions (e.g.
HISTOGRAM over HISTOGRAM).

Close elastic#38308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.