New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct rebuilding of Persian analyzer #38724

Merged
merged 1 commit into from Feb 11, 2019

Conversation

Projects
None yet
2 participants
@mayya-sharipova
Copy link
Contributor

mayya-sharipova commented Feb 11, 2019

Make substitution of \u200C with a space explicit

The problem with this symbol \u200C in a test string, that SHOULD be substituted with space in the rebuilt Persian analyzer, but it is not.

Correcting this line "mappings": [ "\\u200C=> "] <1> to "mappings": [ "\\u200C=>\\u0020"] <1> in
lang-analyzer solves the problem.
This change explicitly says to substitute ZWNJ with a space.

Closes #38188

Correct rebuilt persian analyzer
Make substitution of \u200C with a space explicit

Closes #38188
@cbuescher
Copy link
Member

cbuescher left a comment

Thanks, LGTM

@cbuescher
Copy link
Member

cbuescher left a comment

Actually, looking at #38188 (comment) which was just added it seems other analyzers in this documentation page might have similar issues. Can you check if that failure is related and maybe fix it in the same PR?

@cbuescher
Copy link
Member

cbuescher left a comment

Sorry for the noise, just doule-checked and its the same error on 7.x. I missread the line-numbers and thought they are different.

@mayya-sharipova

This comment has been minimized.

Copy link
Contributor Author

mayya-sharipova commented Feb 11, 2019

@cbuescher thanks a lot

@mayya-sharipova mayya-sharipova merged commit da63ee5 into elastic:master Feb 11, 2019

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details

@mayya-sharipova mayya-sharipova deleted the mayya-sharipova:correct-persian-analyzer-rebuilt branch Feb 11, 2019

mayya-sharipova added a commit that referenced this pull request Feb 11, 2019

Correct rebuilt persian analyzer (#38724) (#38737)
Make substitution of \u200C with a space explicit

The problem with this symbol `\u200C` in a test string, 
that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not.

Correcting this line `"mappings": [ "\\u200C=> "] <1>` to
 `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem.
This change explicitly says to substitute ZWNJ with a space.

Closes #38188

mayya-sharipova added a commit to mayya-sharipova/elasticsearch that referenced this pull request Feb 11, 2019

Correct rebuilt persian analyzer (elastic#38724)
Make substitution of \u200C with a space explicit

The problem with this symbol `\u200C` in a test string, 
that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not.

Correcting this line `"mappings": [ "\\u200C=> "] <1>` to
 `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem.
This change explicitly says to substitute ZWNJ with a space.

Closes elastic#38188

mayya-sharipova added a commit that referenced this pull request Feb 11, 2019

Correct rebuilt persian analyzer (#38724) (#38744)
Make substitution of \u200C with a space explicit

The problem with this symbol `\u200C` in a test string, 
that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not.

Correcting this line `"mappings": [ "\\u200C=> "] <1>` to
 `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem.
This change explicitly says to substitute ZWNJ with a space.

Closes #38188

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Feb 21, 2019

Correct rebuilt persian analyzer (elastic#38724) (elastic#38744)
Make substitution of \u200C with a space explicit

The problem with this symbol `\u200C` in a test string, 
that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not.

Correcting this line `"mappings": [ "\\u200C=> "] <1>` to
 `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem.
This change explicitly says to substitute ZWNJ with a space.

Closes elastic#38188

benwtrent added a commit that referenced this pull request Feb 21, 2019

Correct rebuilt persian analyzer (#38724) (#38744) (#39250)
Make substitution of \u200C with a space explicit

The problem with this symbol `\u200C` in a test string, 
that **SHOULD** be substituted with space in the rebuilt Persian analyzer, but it is not.

Correcting this line `"mappings": [ "\\u200C=> "] <1>` to
 `"mappings": [ "\\u200C=>\\u0020"] <1>` in solves the problem.
This change explicitly says to substitute ZWNJ with a space.

Closes #38188
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment