New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML-DataFrame] Add support for (date) histogram pivots #38725

Merged
merged 4 commits into from Feb 11, 2019

Conversation

Projects
None yet
3 participants
@benwtrent
Copy link
Contributor

benwtrent commented Feb 11, 2019

This adds support for (date) histogram pivots.

These pivots are formatted to allow the same functionality currently available in composite aggregations.

@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 11, 2019


// we expect 17 documents as there shall be 21 days worth of docs
Map<String, Object> indexStats = getAsMap(dataFrameIndex + "/_stats");
assertEquals(21, XContentMapValues.extractValue("_all.total.docs.count", indexStats));

This comment has been minimized.

@hendrikmuhs

hendrikmuhs Feb 11, 2019

Contributor

nit: comment says 17

@hendrikmuhs
Copy link
Contributor

hendrikmuhs left a comment

LGTM

@benwtrent benwtrent merged commit cedd78c into elastic:feature/fib Feb 11, 2019

0 of 6 checks passed

elasticsearch-ci/1 Build triggered for merge commit.
Details
elasticsearch-ci/2 Build triggered for merge commit.
Details
elasticsearch-ci/default-distro Build triggered for merge commit.
Details
elasticsearch-ci/docbldesx Build triggered for merge commit.
Details
elasticsearch-ci/oss-distro-docs Build triggered for merge commit.
Details
elasticsearch-ci/packaging-sample Build triggered for merge commit.
Details

@benwtrent benwtrent deleted the benwtrent:feature/ml-dataframe-add-histo-pivot branch Feb 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment