New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable removal of retention leases #38751

Merged
merged 1 commit into from Feb 12, 2019

Conversation

Projects
None yet
4 participants
@jasontedor
Copy link
Member

jasontedor commented Feb 11, 2019

This commit introduces the ability to remove retention leases. Explicit removal will be needed to manage retention leases used to increase the likelihood of operation-based recoveries syncing, and for consumers such as ILM.

Relates #37165

Enable removal of retention leases
This commit introduces the ability to remove retention leases. Explicit
removal will be needed to manage retention leases used to increase the
likelihood of operation-based recoveries syncing, and for consumers such
as ILM.
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Feb 11, 2019

synchronized (this) {
assert primaryMode;
if (retentionLeases.contains(id) == false) {
throw new IllegalArgumentException("retention lease with ID [" + id + "] does not exist");

This comment has been minimized.

@jasontedor

jasontedor Feb 11, 2019

Author Member

This will change to a RetentionLeaseNotFoundException with the integration of #38754.

@dnhatn

dnhatn approved these changes Feb 12, 2019

Copy link
Contributor

dnhatn left a comment

LGTM.

@jasontedor jasontedor merged commit 58a7716 into elastic:master Feb 12, 2019

7 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit that referenced this pull request Feb 12, 2019

Enable removal of retention leases (#38751)
This commit introduces the ability to remove retention leases. Explicit
removal will be needed to manage retention leases used to increase the
likelihood of operation-based recoveries syncing, and for consumers such
as ILM.

jasontedor added a commit that referenced this pull request Feb 12, 2019

Enable removal of retention leases (#38751)
This commit introduces the ability to remove retention leases. Explicit
removal will be needed to manage retention leases used to increase the
likelihood of operation-based recoveries syncing, and for consumers such
as ILM.

jasontedor added a commit that referenced this pull request Feb 12, 2019

Enable removal of retention leases (#38751)
This commit introduces the ability to remove retention leases. Explicit
removal will be needed to manage retention leases used to increase the
likelihood of operation-based recoveries syncing, and for consumers such
as ILM.

@jasontedor jasontedor deleted the jasontedor:retention-lease-remove branch Feb 12, 2019

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 12, 2019

Merge branch 'master' into retention-lease-exceptions
* master:
  Enable removal of retention leases (elastic#38751)
  Make the 'get templates' types deprecation message consistent. (elastic#38533)
  Copy retention leases when trim unsafe commits (elastic#37995)
  Fix the version check for LegacyGeoShapeFieldMapper (elastic#38547)

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 12, 2019

Merge branch 'master' into retention-lease-actions
* master:
  Enable removal of retention leases (elastic#38751)
  Make the 'get templates' types deprecation message consistent. (elastic#38533)
  Copy retention leases when trim unsafe commits (elastic#37995)
  Fix the version check for LegacyGeoShapeFieldMapper (elastic#38547)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment