Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blob store compression fix #39073

Conversation

Projects
None yet
4 participants
@henningandersen
Copy link
Contributor

commented Feb 18, 2019

Blob store compression was not enabled for some of the files in
snapshots due to constructor accessing sub-class fields, fixed to
instead accept compress field as constructor param. Also fixed chunk
size validation to work.

Deprecated repositories.fs.compress setting as well to unify.

This will be backported to 7.0 too and the repositories.fs.compress option will be removed in a follow up PR.

Blob store compression fix
Blob store compression was not enabled for some of the files in
snapshots due to constructor accessing sub-class fields, fixed to
instead accept compress field as constructor param. Also fixed chunk
size validation to work.

Deprecated repositories.fs.compress setting as well to unify.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 18, 2019

@original-brownbear
Copy link
Member

left a comment

LGTM, thanks @henningandersen

@henningandersen henningandersen merged commit f5fc163 into elastic:master Feb 20, 2019

8 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

henningandersen added a commit that referenced this pull request Feb 20, 2019

Blob store compression fix (#39073)
Blob store compression was not enabled for some of the files in
snapshots due to constructor accessing sub-class fields. Fixed to
instead accept compress field as constructor param. Also fixed chunk
size validation to work.

Deprecated repositories.fs.compress setting as well to be able to unify
in a future commit.

henningandersen added a commit that referenced this pull request Feb 20, 2019

Blob store compression fix (#39073)
Blob store compression was not enabled for some of the files in
snapshots due to constructor accessing sub-class fields. Fixed to
instead accept compress field as constructor param. Also fixed chunk
size validation to work.

Deprecated repositories.fs.compress setting as well to be able to unify
in a future commit.

henningandersen added a commit to henningandersen/elasticsearch that referenced this pull request Feb 25, 2019

Unify blob store compress setting
Blob store compression was all implemented generally, except reading the
setting for it. Moved the setting to BlobStoreRepository to unify this.
Also removed deprecated env setting 'repositories.fs.compress'.

This is a follow up on elastic#39073

henningandersen added a commit to henningandersen/elasticsearch that referenced this pull request Feb 27, 2019

Unify blob store compress setting
Added breaking changes documentation on the removed
'repositories.fs.compress' setting.

This is a follow up on elastic#39073

henningandersen added a commit that referenced this pull request Feb 28, 2019

Unify blob store compress setting (#39346)
Blob store compression was all implemented generally, except reading the
setting for it. Moved the setting to BlobStoreRepository to unify this.
Also removed deprecated env setting 'repositories.fs.compress'.

This is a follow up on #39073

@jakelandis jakelandis added v7.0.0-rc2 and removed v7.0.0 labels Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.