Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to IndicesQueryCache. #39099

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
4 participants
@jpountz
Copy link
Contributor

commented Feb 19, 2019

This commit adds the following:

  • more tests to IndicesServiceCloseTests, one of them found a bug in the order
    in which IndicesQueryCache#onClose and
    IndicesService.indicesRefCount#decRef are called.
  • made IndicesQueryCache.stats2 a synchronized map. All writes to it are
    already protected by the lock of the Lucene cache, but the final read from
    an assertion in IndicesQueryCache#close() was not so this change should
    avoid any potential visibility issues.
  • human-readable toStrings to make debugging easier.

Relates #37117

Enhancements to IndicesQueryCache.
This commit adds the following:
 - more tests to IndicesServiceCloseTests, one of them found a bug in the order
   in which `IndicesQueryCache#onClose` and
   `IndicesService.indicesRefCount#decRef` are called.
 - made `IndicesQueryCache.stats2` a synchronized map. All writes to it are
   already protected by the lock of the Lucene cache, but the final read from
   an assertion in `IndicesQueryCache#close()` was not so this change should
   avoid any potential visibility issues.
 - human-readable `toString`s to make debugging easier.

Relates #37117
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2019

@danielmitterdorfer
Copy link
Member

left a comment

LGTM

@jpountz jpountz merged commit c24e4ae into elastic:master Mar 4, 2019

8 checks passed

CLA Commit author is a member of Elasticsearch
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@jpountz jpountz deleted the jpountz:enhancement/IndicesQueryCache branch Mar 4, 2019

jpountz added a commit to jpountz/elasticsearch that referenced this pull request Mar 4, 2019

Enhancements to IndicesQueryCache. (elastic#39099)
This commit adds the following:
 - more tests to IndicesServiceCloseTests, one of them found a bug in the order
   in which `IndicesQueryCache#onClose` and
   `IndicesService.indicesRefCount#decRef` are called.
 - made `IndicesQueryCache.stats2` a synchronized map. All writes to it are
   already protected by the lock of the Lucene cache, but the final read from
   an assertion in `IndicesQueryCache#close()` was not so this change should
   avoid any potential visibility issues.
 - human-readable `toString`s to make debugging easier.

Relates elastic#37117

jpountz added a commit that referenced this pull request Mar 4, 2019

Enhancements to IndicesQueryCache. (#39099) (#39626)
This commit adds the following:
 - more tests to IndicesServiceCloseTests, one of them found a bug in the order
   in which `IndicesQueryCache#onClose` and
   `IndicesService.indicesRefCount#decRef` are called.
 - made `IndicesQueryCache.stats2` a synchronized map. All writes to it are
   already protected by the lock of the Lucene cache, but the final read from
   an assertion in `IndicesQueryCache#close()` was not so this change should
   avoid any potential visibility issues.
 - human-readable `toString`s to make debugging easier.

Relates #37117

jpountz added a commit to jpountz/elasticsearch that referenced this pull request Mar 26, 2019

Enhancements to IndicesQueryCache. (elastic#39099)
This commit adds the following:
 - more tests to IndicesServiceCloseTests, one of them found a bug in the order
   in which `IndicesQueryCache#onClose` and
   `IndicesService.indicesRefCount#decRef` are called.
 - made `IndicesQueryCache.stats2` a synchronized map. All writes to it are
   already protected by the lock of the Lucene cache, but the final read from
   an assertion in `IndicesQueryCache#close()` was not so this change should
   avoid any potential visibility issues.
 - human-readable `toString`s to make debugging easier.

Relates elastic#37117

jpountz added a commit to jpountz/elasticsearch that referenced this pull request Mar 26, 2019

Enhancements to IndicesQueryCache. (elastic#39099)
This commit adds the following:
 - made `IndicesQueryCache.stats2` a synchronized map. All writes to it are
   already protected by the lock of the Lucene cache, but the final read from
   an assertion in `IndicesQueryCache#close()` was not so this change should
   avoid any potential visibility issues.
 - human-readable `toString`s to make debugging easier.

Relates elastic#37117

jpountz added a commit that referenced this pull request Mar 26, 2019

Enhancements to IndicesQueryCache. (#39099) (#40445)
This commit adds the following:
 - more tests to IndicesServiceCloseTests, one of them found a bug in the order
   in which `IndicesQueryCache#onClose` and
   `IndicesService.indicesRefCount#decRef` are called.
 - made `IndicesQueryCache.stats2` a synchronized map. All writes to it are
   already protected by the lock of the Lucene cache, but the final read from
   an assertion in `IndicesQueryCache#close()` was not so this change should
   avoid any potential visibility issues.
 - human-readable `toString`s to make debugging easier.

Relates #37117

jpountz added a commit that referenced this pull request Mar 26, 2019

Enhancements to IndicesQueryCache. (#39099) (#40446)
This commit adds the following:
 - made `IndicesQueryCache.stats2` a synchronized map. All writes to it are
   already protected by the lock of the Lucene cache, but the final read from
   an assertion in `IndicesQueryCache#close()` was not so this change should
   avoid any potential visibility issues.
 - human-readable `toString`s to make debugging easier.

Relates #37117

@jakelandis jakelandis added v7.0.0-rc2 and removed v7.0.0 labels Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.