Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Hipchat Watcher actions #39160

Merged
merged 7 commits into from Feb 20, 2019

Conversation

Projects
None yet
4 participants
@dakrone
Copy link
Member

commented Feb 19, 2019

Hipchat has ceased operating, so we are deprecating Hipchat Watcher actions to
be removed in Elasticsearch 7.0.

This also adds a check for hipchat account settings in elasticsearch.yml.
Unfortunately with the current infrastructure we can't check the watches
themselves because they're in an index.

Deprecate Hipchat Watcher actions
Hipchat has ceased operating, so we are deprecating Hipchat Watcher actions to
be removed in Elasticsearch 7.0.

This also adds a check for hipchat account settings in elasticsearch.yml.
Unfortunately with the current infrastructure we can't check the watches
themselves because they're in an index.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Feb 19, 2019

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Feb 20, 2019

@elasticmachine run elasticsearch-ci/1
@elasticmachine run elasticsearch-ci/2
@elasticmachine run elasticsearch-ci/bwc
@elasticmachine run elasticsearch-ci/default-distro

There were some CI/version issues recently which should be resolved now.

@@ -169,6 +169,17 @@ static DeprecationIssue watcherNotificationsSecureSettingsCheck(Settings nodeSet
return null;
}

static DeprecationIssue watcherHipchatNotificationSettingsCheck(Settings nodeSettings, PluginsAndModules plugins) {
if (nodeSettings.getByPrefix("xpack.notification.hipchat.").size() > 0) {
return new DeprecationIssue(DeprecationIssue.Level.CRITICAL,

This comment has been minimized.

Copy link
@jakelandis

jakelandis Feb 20, 2019

Contributor

I think this should be a warning since it only possibly an issue. @gwbrown - thoughts on critical vs. warning ?

This comment has been minimized.

Copy link
@gwbrown

gwbrown Feb 20, 2019

Contributor

Depends on how 7.0 behaves if you leave this setting in place. Most removed node settings are CRITICAL because Elasticsearch will refuse to start if you have unrecognized settings in elasticsearch.yml. I think that's the case here, so CRITICAL is the correct level, although I could be wrong if Watcher is doing something funny with prefix settings.

@jakelandis
Copy link
Contributor

left a comment

LGTM

gwbrown and others added some commits Feb 20, 2019

Update deprecation link to use 7.0 instead of master
Co-Authored-By: dakrone <dakrone@users.noreply.github.com>
@dakrone

This comment has been minimized.

Copy link
Member Author

commented Feb 20, 2019

@elasticmachine run elasticsearch-ci/2

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Feb 20, 2019

Remove Hipchat support from Watcher
Hipchat has been shut down and has previously been deprecated in
Watcher (elastic#39160), therefore we should remove support for these actions.

@dakrone dakrone merged commit 9159b3f into elastic:6.7 Feb 20, 2019

9 checks passed

CLA Commit author has signed the CLA
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@dakrone dakrone deleted the dakrone:deprecate-hipchat-6.7 branch Feb 20, 2019

dakrone added a commit that referenced this pull request Feb 25, 2019

Remove Hipchat support from Watcher (#39199)
Hipchat has been shut down and has previously been deprecated in
Watcher (#39160), therefore we should remove support for these actions.

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Feb 25, 2019

Remove Hipchat support from Watcher (elastic#39199)
Hipchat has been shut down and has previously been deprecated in
Watcher (elastic#39160), therefore we should remove support for these actions.

dakrone added a commit to dakrone/elasticsearch that referenced this pull request Feb 25, 2019

Remove Hipchat support from Watcher (elastic#39199)
Hipchat has been shut down and has previously been deprecated in
Watcher (elastic#39160), therefore we should remove support for these actions.

dakrone added a commit that referenced this pull request Feb 25, 2019

Remove Hipchat support from Watcher (#39373)
* Remove Hipchat support from Watcher (#39199)

Hipchat has been shut down and has previously been deprecated in
Watcher (#39160), therefore we should remove support for these actions.

* Add migrate note

dakrone added a commit that referenced this pull request Feb 25, 2019

Remove Hipchat support from Watcher (#39374)
* Remove Hipchat support from Watcher (#39199)

Hipchat has been shut down and has previously been deprecated in
Watcher (#39160), therefore we should remove support for these actions.

* Add migrate note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.