Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: fix COUNT DISTINCT column name #39537

Merged
merged 2 commits into from Mar 1, 2019

Conversation

Projects
None yet
5 participants
@astefan
Copy link
Contributor

commented Feb 28, 2019

This PR removes the need for a custom named column in case of a DISTINCT COUNT function.

Fixes #39511.

@astefan astefan requested review from costin and matriv Feb 28, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented Feb 28, 2019

@costin

costin approved these changes Mar 1, 2019

Copy link
Member

left a comment

LGTM.
Please add the versioning as well (likely 6.x+)

@matriv

matriv approved these changes Mar 1, 2019

Copy link
Contributor

left a comment

LGTM

@astefan astefan merged commit 9412a2e into elastic:master Mar 1, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@astefan astefan deleted the astefan:39511_fix branch Mar 1, 2019

astefan added a commit that referenced this pull request Mar 1, 2019

astefan added a commit that referenced this pull request Mar 1, 2019

astefan added a commit that referenced this pull request Mar 1, 2019

@astefan astefan removed the v6.6.2 label Mar 4, 2019

@jakelandis jakelandis added v7.0.0-rc2 and removed v7.0.0 labels Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.