Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: suppress Geosql tests if locale doesn't use - for negative numbers #39664

Merged
merged 2 commits into from Mar 8, 2019
Merged

SQL: suppress Geosql tests if locale doesn't use - for negative numbers #39664

merged 2 commits into from Mar 8, 2019

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Mar 4, 2019

Some locales are using − for negative numbers, which is causing Geo
tests to fail on negative coordinates, since WKT parser cannot parse
non-ascii - signs.

@imotov
SQL: suppress Geosql tests if locale doesn't use - for negative numbers
41c0232 
Some locales are using `−` for negative numbers, which is causing Geo
tests to fail on negative coordinates, since WKT parser cannot parse
non-ascii - signs.
@imotov imotov added >bug :Analytics/Geo Indexing, search aggregations of geo points and shapes :Analytics/SQL SQL querying labels Mar 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

matriv
matriv approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin self-requested a review March 7, 2019 15:41
costin
costin approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

astefan
astefan approved these changes Mar 7, 2019
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imotov imotov merged commit 943f4eb into elastic:geosql Mar 8, 2019
@imotov imotov deleted the ignore-unsupported-h2-locales branch May 1, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

@astefan astefan astefan approved these changes

@matriv matriv matriv approved these changes

Assignees
No one assigned
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes :Analytics/SQL SQL querying >bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@imotov @elasticmachine @costin @astefan @matriv