Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugins/repository-gcs: Update google-cloud-storage/core to 1.59.0 #39748

Merged

Conversation

wuurrd
Copy link
Contributor

@wuurrd wuurrd commented Mar 6, 2019

#39366

  • Have you signed the contributor license agreement? Yes
  • Have you followed the contributor guidelines? Yes
  • If submitting code, have you built your formula locally prior to submission with gradle check? Yes
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed. Yes
  • If submitting code, have you checked that your submission is for an OS that we support? Yes
  • If you are submitting this code for a class then read our policy for that. Not for a class

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not sufficient. Please run :plugins:repository-gcs:precommit and you will see that you need to update the SHAs.

@jasontedor
Copy link
Member

Thanks for the pull request @wuurrd. I left a comment about some additional changes that are needed.

@jasontedor jasontedor added the :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs label Mar 6, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@wuurrd
Copy link
Contributor Author

wuurrd commented Mar 7, 2019

@jasontedor Hey, thanks for the review - I ran the commands and added a new patch. What else needs to be done?

@jasontedor
Copy link
Member

@elasticmachine test this please

@jasontedor
Copy link
Member

@wuurrd Thanks for updating, we will run this through CI now.

@wuurrd
Copy link
Contributor Author

wuurrd commented Mar 10, 2019

@jasontedor: Is there a simple way to retry the failed job?

17:08:56 Vagrant was unable to communicate with the guest machine within
17:08:56 
17:08:56 the configured ("config.vm.boot_timeout" value) time period.
17:08:56 > Task :qa:vagrant:vagrantCentos7#up FAILED
17:08:56 :qa:vagrant:vagrantCentos7#up (Thread[Daemon worker,5,main]) completed. Took 5 mins 22.898 secs.

@original-brownbear
Copy link
Member

Jenkins run elasticsearch-ci/packaging-sample

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jasontedor jasontedor merged commit dc2d707 into elastic:master Mar 10, 2019
jasontedor pushed a commit that referenced this pull request Mar 10, 2019
…39748)

* plugins/repository-gcs: Update google-cloud-storage /
google-cloud-core to 1.59.0

* plugins: Update sha1 for google-cloud-core & google-cloud-storage
jasontedor pushed a commit that referenced this pull request Mar 10, 2019
…39748)

* plugins/repository-gcs: Update google-cloud-storage /
google-cloud-core to 1.59.0

* plugins: Update sha1 for google-cloud-core & google-cloud-storage
jasontedor pushed a commit that referenced this pull request Mar 10, 2019
…39748)

* plugins/repository-gcs: Update google-cloud-storage /
google-cloud-core to 1.59.0

* plugins: Update sha1 for google-cloud-core & google-cloud-storage
@jasontedor
Copy link
Member

Thanks @wuurrd. I have integrated this to the 6.7, 7.0, 7.x, and master branches.

@wuurrd wuurrd deleted the wuurrd/update-google-cloud-dependencies branch March 11, 2019 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants