New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins/repository-gcs: Update google-cloud-storage/core to 1.59.0 #39748
plugins/repository-gcs: Update google-cloud-storage/core to 1.59.0 #39748
Conversation
google-cloud-core to 1.59.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not sufficient. Please run :plugins:repository-gcs:precommit
and you will see that you need to update the SHAs.
Thanks for the pull request @wuurrd. I left a comment about some additional changes that are needed. |
Pinging @elastic/es-distributed |
@jasontedor Hey, thanks for the review - I ran the commands and added a new patch. What else needs to be done? |
@elasticmachine test this please |
@wuurrd Thanks for updating, we will run this through CI now. |
@jasontedor: Is there a simple way to retry the failed job?
|
Jenkins run elasticsearch-ci/packaging-sample |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…39748) * plugins/repository-gcs: Update google-cloud-storage / google-cloud-core to 1.59.0 * plugins: Update sha1 for google-cloud-core & google-cloud-storage
…39748) * plugins/repository-gcs: Update google-cloud-storage / google-cloud-core to 1.59.0 * plugins: Update sha1 for google-cloud-core & google-cloud-storage
…39748) * plugins/repository-gcs: Update google-cloud-storage / google-cloud-core to 1.59.0 * plugins: Update sha1 for google-cloud-core & google-cloud-storage
Thanks @wuurrd. I have integrated this to the 6.7, 7.0, 7.x, and master branches. |
#39366
gradle check
? Yes