Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Refactor Literals serialization method #40058

Merged
merged 1 commit into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@imotov
Copy link
Member

imotov commented Mar 14, 2019

Since other classes besides intervals can be serialized as part of
the Cursor, the getNamedWritables method should be moved from Intervals
to a more generic class Literals.

Relates to #39973

SQL: Refactor Literals serialization method
Since other classes besides intervals can be serialized as part of
the Cursor, the getNamedWritables method should be moved from Intervals
to a more generic class Literals.

Relates to #39973
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 14, 2019

@matriv

matriv approved these changes Mar 14, 2019

Copy link
Contributor

matriv left a comment

LGTM

@astefan
Copy link
Contributor

astefan left a comment

LGTM

@imotov imotov merged commit 8579235 into elastic:master Mar 15, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

imotov added a commit that referenced this pull request Mar 15, 2019

SQL: Refactor Literals serialization method (#40058)
Since other classes besides intervals can be serialized as part of
the Cursor, the getNamedWritables method should be moved from Intervals
to a more generic class Literals.

Relates to #39973

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 16, 2019

Merge remote-tracking branch 'elastic/master' into remove-cluster-sta…
…te-size-hard-failure

* elastic/master:
  use shell with JAVA_HOME for starting archive (elastic#40118)
  Remove Migration Upgrade and Assistance APIs (elastic#40075)
  Revert "Fix IndexSearcherWrapper visibility (elastic#39071)"
  Remove transport name from tcp channel (elastic#40074)
  Document the limitation around field aliases and percolator. (elastic#40073)
  SQL: Refactor Literals serialization method (elastic#40058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.