Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Migration Assistance and Upgrade APIs #40072

Merged
merged 9 commits into from Mar 15, 2019

Conversation

Projects
None yet
4 participants
@gwbrown
Copy link
Contributor

gwbrown commented Mar 14, 2019

The Migration Assistance API has been functionally replaced with the
Deprecation Info API, and the Migration Upgrade API is not in use for
the 6.x to 7.x upgrade, and may or may not be used for the 7.x to 8.x
upgrade. It is currently only useful for repairing clusters which were not
properly prepared for the 5.x to 6.x upgrade.
Therefore, these APIs are now deprecated, and the docs are updated
to point users to the correct resources for preparing for an upgrade to 7.x.

Relates to #40014

gwbrown added some commits Mar 14, 2019

Deprecate Migration Assistance and Upgrade APIs
The Migration Assistance API has been functionally replaced with the
Deprecation Info API, and the Migration Upgrade API is not in use for
the 6.x to 7.x upgrade, and may not be used for the 7.x to 8.x upgrade.
It is currently only useful for repairing clusters which were not
properly prepared for the 5.x to 6.x upgrade. Therefore, these APIs are
deprecated.
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 14, 2019

@gwbrown

This comment has been minimized.

Copy link
Contributor Author

gwbrown commented Mar 14, 2019

This also needs to deprecate the appropriate HLRC classes. Done

@@ -6,8 +6,13 @@
<titleabbrev>Migration assistance</titleabbrev>
++++

The Migration Assistance API analyzes existing indices in the cluster and
returns the information about indices that require some changes before the
IMPORTANT: The Migration Assistance API is deprecated, use the

This comment has been minimized.

@jakelandis

jakelandis Mar 15, 2019

Contributor

If someone uses this API in 6.7, will it return correct information ?

This comment has been minimized.

@gwbrown

gwbrown Mar 15, 2019

Author Contributor

I've made a tweak to this to make sure the behavior aligns, but as of this PR, if used in 6.7, this API will correctly identify which indices need to be reindexed, including internal indices. It will only say that indices need to be "upgraded" if they were not properly upgraded before upgrading the cluster to 6 and need to be fixed using the Migration Upgrade API.

deprecated[6.7, Use the {kibana-ref}/upgrade-assistant.html[{kib} Upgrade
Assistant] or <<reindex-upgrade,Reindex manually>> before upgrading.] The
Migration Upgrade API performs the upgrade of internal indices to make them
compatible with version 6 of Elasticsearch.

This comment has been minimized.

@jakelandis

jakelandis Mar 15, 2019

Contributor

If someone uses this API in 6.7 will it work correctly ?

This comment has been minimized.

@gwbrown

gwbrown Mar 15, 2019

Author Contributor

I've made a tweak to this to make sure the behavior aligns, but as of this PR, if used in 6.7, the Upgrade API will only upgrade indices that need to be upgraded from their 5.x format (i.e. they were not upgraded before upgrading the cluster). Otherwise, it will just say that the index needs to be reindexed.

That is, if the .watches-6 index was created and upgraded in 5.x, the Upgrade API will refuse to upgrade it and just say that it needs to be reindexed.

@jakelandis

This comment has been minimized.

Copy link
Contributor

jakelandis commented Mar 15, 2019

A couple questions, but would also like a thumbs up from @bleskes on this and the related #40075

EDIT: got a SGTM for this direction

gwbrown added some commits Mar 15, 2019

@jakelandis
Copy link
Contributor

jakelandis left a comment

LGTM

lcawl and others added some commits Mar 15, 2019

Capitalization
Co-Authored-By: gwbrown <gordon.brown@elastic.co>
Capitalization
Co-Authored-By: gwbrown <gordon.brown@elastic.co>
Capitalization
Co-Authored-By: gwbrown <gordon.brown@elastic.co>
Capitalization
Co-Authored-By: gwbrown <gordon.brown@elastic.co>
@gwbrown

This comment has been minimized.

Copy link
Contributor Author

gwbrown commented Mar 15, 2019

Thanks for the corrections @lcawl!

@lcawl

This comment has been minimized.

Copy link
Contributor

lcawl commented Mar 15, 2019

I've created the following PR to make similar changes in the Installation and Upgrade Guide: elastic/stack-docs#247

@lcawl

lcawl approved these changes Mar 15, 2019

Copy link
Contributor

lcawl left a comment

Documentation LGTM and builds successfully

@gwbrown gwbrown merged commit 101d780 into elastic:6.7 Mar 15, 2019

9 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.