Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transport name from tcp channel #40074

Merged
merged 2 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@tbrooks8
Copy link
Contributor

tbrooks8 commented Mar 14, 2019

Currently, we maintain a transport name ("mock-nio", "nio", "netty")
that is passed to a TcpTransportChannel when a request is received.
The value of this name is to associate with the task when we register a
task with the task manager. However, it is only possible to run ES with
one transport, so having an implementation specific name is unnecessary.
This commit removes the name and replaces it with the generic
"transport".

Remote transport name from tcp channel
Currently, we maintain a transport name ("mock-nio", "nio", "netty")
that is passed to a `TcpTransportChannel` when a request is received.
The value of this name is to associate with the task when we register a
task with the task manager. However, it is only possible to run ES with
one transport, so having an implementation specific name is unnecessary.
This commit removes the name and replaces it with the generic
"tcp-transport".
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 14, 2019

@tbrooks8

This comment has been minimized.

Copy link
Contributor Author

tbrooks8 commented Mar 14, 2019

Currently our task types are:

  • direct (for requests to the local node)
  • transport (for tasks created in the TransportAction and PrimaryReplicaSyner)
  • persistent
  • netty/nio/mock-nio (for tasks created in RequestHandlerRegistry)

The last one will be replaced by tcp-transport in this PR. Maybe it should just be transport to match TransportAction and PrimaryReplicaSyner? I don't know how much the different names matter.

@tbrooks8 tbrooks8 changed the title Remote transport name from tcp channel Remove transport name from tcp channel Mar 14, 2019

@s1monw

s1monw approved these changes Mar 15, 2019

Copy link
Contributor

s1monw left a comment

+1 to rename to transport

@tbrooks8 tbrooks8 merged commit 9026c91 into elastic:master Mar 15, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

tbrooks8 added a commit that referenced this pull request Mar 15, 2019

Remove transport name from tcp channel (#40074)
Currently, we maintain a transport name ("mock-nio", "nio", "netty")
that is passed to a `TcpTransportChannel` when a request is received.
The value of this name is to associate with the task when we register a
task with the task manager. However, it is only possible to run ES with
one transport, so having an implementation specific name is unnecessary.
This commit removes the name and replaces it with the generic
"transport".

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 16, 2019

Merge remote-tracking branch 'elastic/master' into remove-cluster-sta…
…te-size-hard-failure

* elastic/master:
  use shell with JAVA_HOME for starting archive (elastic#40118)
  Remove Migration Upgrade and Assistance APIs (elastic#40075)
  Revert "Fix IndexSearcherWrapper visibility (elastic#39071)"
  Remove transport name from tcp channel (elastic#40074)
  Document the limitation around field aliases and percolator. (elastic#40073)
  SQL: Refactor Literals serialization method (elastic#40058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.