Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove es.cluster_state.size hard failure #40111

Merged
merged 2 commits into from Mar 16, 2019

Conversation

Projects
None yet
3 participants
@jasontedor
Copy link
Member

jasontedor commented Mar 15, 2019

In 6.7.0 we introduced a system property to return the old behavior of
computing and sending the compressed size of the cluster state on
cluster state endpoints. In 7.0.0, we removed this behavior but hard
failed usage of this system property (to clearly inform users this
behavior is gone). In this commit, intending to target 8.0.0 only, we
remove this detection as it should no longer be needed; that is, we now
treat this as dead code.

Relates #39806
Relates #39827
Relates #39951
Relates #40016
Relates #40061

Remove es.cluster_state.size hard failure
In 6.7.0 we introduced a system property to return the old behavior of
computing and sending the compressed size of the cluster state on
cluster state endpoints. In 7.0.0, we removed this behavior but hard
failed usage of this system property (to clearly inform users this
behavior is gone). In this commit, intending to target 8.0.0 only, we
remove this detection as it should no longer be needed; that is, we now
treat this as dead code.
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 15, 2019

@DaveCTurner
Copy link
Contributor

DaveCTurner left a comment

LGTM

Merge remote-tracking branch 'elastic/master' into remove-cluster-sta…
…te-size-hard-failure

* elastic/master:
  use shell with JAVA_HOME for starting archive (#40118)
  Remove Migration Upgrade and Assistance APIs (#40075)
  Revert "Fix IndexSearcherWrapper visibility (#39071)"
  Remove transport name from tcp channel (#40074)
  Document the limitation around field aliases and percolator. (#40073)
  SQL: Refactor Literals serialization method (#40058)

@jasontedor jasontedor merged commit 87627fc into elastic:master Mar 16, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@jasontedor jasontedor deleted the jasontedor:remove-cluster-state-size-hard-failure branch Mar 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.