Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexSearcher wrappers interaction with AssertingIndexSearcher #40112

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jimczi
Copy link
Member

jimczi commented Mar 15, 2019

This commit ensures that we delegate the creation of the query weight to the AssertingIndexSearcher
when possible (if the query does not need to access distributed frequency statistics). This fixes test failures that uses a ContextIndexSearcher wrapped with an AssertingIndexSearcher.

Relates #39071

Fix IndexSearcher wrappers interaction with AssertingIndexSearcher
This commit ensures that we delegate the creation of the query weight to the AssertingIndexSearcher
when possible (if the query does not need to access distributed frequency statistics). This fixes test failures
that uses a ContextIndexSearcher wrapped with an AssertingIndexSearcher.

Relates #39071
@elasticmachine

This comment has been minimized.

Copy link

elasticmachine commented Mar 15, 2019

@jimczi

This comment has been minimized.

Copy link
Member Author

jimczi commented Mar 15, 2019

I had to revert #39071 because it breaks some tests so I am closing this pr and will work on a different approach.

@jimczi jimczi closed this Mar 15, 2019

@jimczi jimczi deleted the jimczi:bug/xindex_searcher_weight branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.