Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date and date_nanos conversion to the numeric_type sort option #40199

Merged
merged 3 commits into from Mar 19, 2019

Conversation

Projects
None yet
3 participants
@jimczi
Copy link
Member

commented Mar 19, 2019

This change adds an option to convert a date field to nanoseconds resolution
and a date_nanos field to millisecond resolution when sorting.
The resolution of the sort can be set using the numeric_type option of the
field sort builder. The conversion is done at the shard level and is restricted
to dates from 1970 to 2262 for the nanoseconds resolution in order to avoid
numeric overflow.

Add date and date_nanos conversion to the numeric_type sort option
This change adds an option to convert a `date` field to nanoseconds resolution
 and a `date_nanos` field to millisecond resolution when sorting.
The resolution of the sort can be set using the `numeric_type` option of the
field sort builder. The conversion is done at the shard level and is restricted
to dates from 1970 to 2262 for the nanoseconds resolution in order to avoid
numeric overflow.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Mar 19, 2019

@jimczi jimczi requested a review from jpountz Mar 19, 2019

@jpountz
Copy link
Contributor

left a comment

One question, other than that LGTM.

@jimczi jimczi merged commit d234ef7 into elastic:master Mar 19, 2019

9 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@jimczi jimczi deleted the jimczi:date_sort_conversion branch Mar 19, 2019

jimczi added a commit to jimczi/elasticsearch that referenced this pull request Mar 19, 2019

Add date and date_nanos conversion to the numeric_type sort option (e…
…lastic#40199)

This change adds an option to convert a `date` field to nanoseconds resolution
 and a `date_nanos` field to millisecond resolution when sorting.
The resolution of the sort can be set using the `numeric_type` option of the
field sort builder. The conversion is done at the shard level and is restricted
to dates from 1970 to 2262 for the nanoseconds resolution in order to avoid
numeric overflow.

jimczi added a commit that referenced this pull request Mar 20, 2019

Add date and date_nanos conversion to the numeric_type sort option (#…
…40199) (#40224)

This change adds an option to convert a `date` field to nanoseconds resolution
 and a `date_nanos` field to millisecond resolution when sorting.
The resolution of the sort can be set using the `numeric_type` option of the
field sort builder. The conversion is done at the shard level and is restricted
to dates from 1970 to 2262 for the nanoseconds resolution in order to avoid
numeric overflow.

pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Mar 25, 2019

Add date and date_nanos conversion to the numeric_type sort option (e…
…lastic#40199)

This change adds an option to convert a `date` field to nanoseconds resolution
 and a `date_nanos` field to millisecond resolution when sorting.
The resolution of the sort can be set using the `numeric_type` option of the
field sort builder. The conversion is done at the shard level and is restricted
to dates from 1970 to 2262 for the nanoseconds resolution in order to avoid
numeric overflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.