Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
SQL: rewrite ROUND and TRUNCATE functions with a different optional parameter handling method #40242
The optional parameter for these two functions was handled in the constructor by passing the value of
This affected the comparison operation from the Analyzer and the same function that was already resolved wouldn't match the new function found because the new one had no second parameter while the resolved one had the parameter
This PR also fixes a bug with ATAN2 and POWER functions which didn't have any Painless methods.
3 similar comments
costin left a comment
Considering the timing and everything, I'm fine with the approach.