SQL: Fix metric aggs on date/time to not return double #40377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously metric aggregations on date fields would return a double which caused errors when trying to apply scalar functions on top, e.g.: ``` SELECT YEAR(MAX(date)) FROM test ``` Fixes: elastic#40376
matriv
added
>bug
v7.0.0
:Analytics/SQL
|
Pinging @elastic/es-search |
costin
approved these changes
Mar 22, 2019
| return tryExtractDateTime(innerKey != null && v instanceof Map ? ((Map<?, ?>) v).get(innerKey) : v); | ||
| } | ||
|
|
||
| private Object tryExtractDateTime(Object object) { |
There was a problem hiding this comment.
handleDateTime/maybeDateTime sounds better.
astefan
reviewed
Mar 23, 2019
| this.name = name; | ||
| this.property = property; | ||
| this.innerKey = innerKey; | ||
| this. isDateTimeBased =isDateTimeBased; |
| @@ -279,6 +279,8 @@ aggMinWithAlias | |||
| SELECT gender g, MIN(emp_no) m FROM "test_emp" GROUP BY g ORDER BY gender; | |||
| aggMinOnDateTime | |||
| SELECT gender, MIN(birth_date) m FROM "test_emp" GROUP BY gender ORDER BY gender; | |||
There was a problem hiding this comment.
If this test here wasn't complaining before, this means that our SQL spec test case infrastructure isn't actually comparing an actual date type of data, right? Otherwise, the test would have failed.
If so, I would like to see a test with MIN(date_field) in CSV spec test case infra, if possible. I have seen the unit test that compares the metric agg key with an actual date (assertEquals(DateUtils.asDateTime((long) innerValue , zoneId), extractor.extract(bucket));) but I believe our tests would be more complete if there would be an integration test as well (CSV-spec in this case).
pgomulka
pushed a commit
to pgomulka/elasticsearch
that referenced
this pull request
Mar 25, 2019
Previously metric aggregations on date fields would return a double which caused errors when trying to apply scalar functions on top, e.g.: ``` SELECT YEAR(MAX(date)) FROM test ``` Fixes: elastic#40376
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously metric aggregations on date fields would return a double
which caused errors when trying to apply scalar functions on top, e.g.:
Fixes: #40376
Fixes: #39492