Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update eager-global-ordinals.asciidoc #40620
Adding clarification on global ordinals.
Adding clarification on global ordinals. Global ordinals are loaded as-needed by default as opposed to up-front. setting `eager_global_ordinals: true` will load them up-front and keep them up-to-date, as opposed to lazy loading when needed. eager_global_ordinals is false by default, just trying to clarify that bit.
I think the doc can be further improved, but I'm not sure how. Here's some external blogs gave a good explanation:
Enable eager global ordinals to improve the performance of high-cardinality terms aggregations
Building global ordinals eagerly should improve such aggregations and make response times more consistent, as the related data structure will be created when segments are refreshed, as opposed to the first query after each refresh.
Note that if global ordinals are eagerly built, this will impact write performance because new global ordinals will be created on every refresh. To minimize the additional workload caused by frequently building global ordinals due to frequent refreshes, increase the refresh interval.
mayya-sharipova left a comment
@Leaf-Lin Thanks for your contributions.
I actually think that the original wording that we had in the documentation is more clear and specific than the one you suggested. You suggested as "as-needed" but it is not clear when they are needed. If you want, we can incorporate both your suggestions and our original statement to something like this:
"global ordinals are loaded as needed for a search or aggregation request..."
Another note - please keep the text wrapped around 80 columns.
Also, we can NOT just copy text from external blogs. If you have some original content to enhance documentation, please go ahead. You contribution is very much welcome.
I'm not suggesting to copy/paste content from other blogs, but I found the other blog seems to explain more clearly about what the setting is about.
I think the doc can be improved to incorporate more clarity, but I'm not in the position to do so.