Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lintian overrides #41561

Merged
merged 7 commits into from May 8, 2019
Merged

Update lintian overrides #41561

merged 7 commits into from May 8, 2019

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Apr 26, 2019

The deb package has been updated several times in the past to contain
overrides in order to pass lintian inspection. However, there have never
been any tests to ensure we do not fallback to failure. This commit
updates the overrides file given things that have changed since 2.x like
adding ML and bundling the jdk.

closes #17185

The deb package has been updated several times in the past to contain
overrides in order to pass lintian inspection. However, there have never
been any tests to ensure we do not fallback to failure. This commit
updates the overrides file given things that have changed since 2.x like
adding ML and bundling the jdk.

closes elastic#17185
@rjernst rjernst added >bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v8.0.0 v7.2.0 labels Apr 26, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

requires 'bash'

// versions found on oldest supported distro, centos-6
// nocommit: why are bash and libc only required for deb?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RPM config requires /bin/bash.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libc needs to be addressed indeed though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some more research and found rpm automatically finds lib deps based on binary paths, eg for libc being needed by /bin/bash, so that is why it is not needed in rpm as a direct dependency.

@rjernst
Copy link
Member Author

rjernst commented May 6, 2019

@jasontedor Do you have any other comments on this?

@rjernst
Copy link
Member Author

rjernst commented May 6, 2019

@elasticmachine run elasticsearch-ci/packaging

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.


# bundled JDK
embedded-library
arch-dependent-file-in-usr-share usr/share/elasticsearch/jdk/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do want to consider moving these at some point to a more proper location?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think we should, but I was worried about the broad impact, although I guess we could keep plugins there? I will open a follow-up for discussion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah a discussion is good. The modules directory presents an interesting dilemma too.

hardening-no-pie usr/share/elasticsearch/jdk/bin/*
hardening-no-pie usr/share/elasticsearch/jdk/lib/*

# the system java version that lintian assumes is far behind what elasticsearch uses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's cute.

@rjernst
Copy link
Member Author

rjernst commented May 8, 2019

@elasticmachine run elasticsearch-ci/1

@rjernst rjernst merged commit 7276fb6 into elastic:master May 8, 2019
@rjernst rjernst deleted the lintian2 branch May 8, 2019 14:31
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 8, 2019
The deb package has been updated several times in the past to contain
overrides in order to pass lintian inspection. However, there have never
been any tests to ensure we do not fallback to failure. This commit
updates the overrides file given things that have changed since 2.x like
adding ML and bundling the jdk.

closes elastic#17185
rjernst added a commit that referenced this pull request May 8, 2019
The deb package has been updated several times in the past to contain
overrides in order to pass lintian inspection. However, there have never
been any tests to ensure we do not fallback to failure. This commit
updates the overrides file given things that have changed since 2.x like
adding ML and bundling the jdk.

closes #17185
Megamiun pushed a commit to Megamiun/elasticsearch that referenced this pull request May 18, 2019
The deb package has been updated several times in the past to contain
overrides in order to pass lintian inspection. However, there have never
been any tests to ensure we do not fallback to failure. This commit
updates the overrides file given things that have changed since 2.x like
adding ML and bundling the jdk.

closes elastic#17185
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
The deb package has been updated several times in the past to contain
overrides in order to pass lintian inspection. However, there have never
been any tests to ensure we do not fallback to failure. This commit
updates the overrides file given things that have changed since 2.x like
adding ML and bundling the jdk.

closes elastic#17185
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts Team:Delivery Meta label for Delivery team v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ubuntu 14 complaining that the deb package is bad quality
5 participants