Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enrich policy execute API #41762

Merged
merged 6 commits into from May 22, 2019

Conversation

Projects
None yet
3 participants
@hub-cap
Copy link
Contributor

commented May 2, 2019

This commit wires up the Rest calls and Transport calls for execute
enrich policy, as well as tests and rest spec additions.

Add enrich policy execute API
This commit wires up the Rest calls and Transport calls for execute
enrich policy, as well as tests and rest spec additions.
@elasticmachine

This comment has been minimized.

Copy link

commented May 2, 2019

@martijnvg
Copy link
Member

left a comment

Looks good, I left two comments.


@Override
public AcknowledgedResponse newResponse() {
return new AcknowledgedResponse();

This comment has been minimized.

Copy link
@martijnvg

martijnvg May 6, 2019

Member

Maybe we should define a different response class here? Right now we return only a boolean, but we return more in the future and then it is easier bwc wise if we have a custom class? Also toXContent() returns acknowledge in the body and I think something like executed is better?

This comment has been minimized.

Copy link
@hub-cap

hub-cap May 8, 2019

Author Contributor

This is just a dummy response for now. I assumed we would change it to a more robust response once more information about the execution are bubbled up.

This comment has been minimized.

Copy link
@martijnvg

public RestExecuteEnrichPolicyAction(final Settings settings, final RestController controller) {
super(settings);
controller.registerHandler(RestRequest.Method.PUT, "/_enrich/policy/{name}/_execute", this);

This comment has been minimized.

Copy link
@martijnvg

martijnvg May 6, 2019

Member

I think we should add a POST variant here too. We do that for other execute APIs too.

hub-cap added some commits May 8, 2019

@martijnvg
Copy link
Member

left a comment

LGTM

@martijnvg

This comment has been minimized.

Copy link
Member

commented May 14, 2019

@elasticmachine run elasticsearch-ci/1

@hub-cap hub-cap merged commit 833c9d1 into elastic:enrich May 22, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

hub-cap added a commit that referenced this pull request May 24, 2019

Add enrich policy execute API (#41762)
This commit wires up the Rest calls and Transport calls for execute
enrich policy, as well as tests and rest spec additions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.