Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

High level REST client parameters look wrong due indirectness and side effects (#39666) #42128

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ojasgulati
Copy link

commented May 13, 2019

I just gave a shot to this issue, please let me know if i am in right direction 馃槂

@elasticmachine

This comment has been minimized.

Copy link

commented May 15, 2019

@tvernum

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@ojasgulati
You seem to have mixed some watcher changes in with your HL Rest Client changes.
Can you split them into separate PRs so that they can be reviewed independently.

Thanks.

@tvernum

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@elasticmachine Test this please

@ojasgulati

This comment has been minimized.

Copy link
Author

commented May 15, 2019

@tvernum I am having a problem in removing previous commits of mine from parameters branch. can you help me how can I split it?

High level REST client parameters (#39666)
This commit will use parameters in request object

@ojasgulati ojasgulati force-pushed the ojasgulati:parameters_39666 branch from 5fd90b3 to 71caa24 May 15, 2019

@ojasgulati

This comment has been minimized.

Copy link
Author

commented May 15, 2019

@tvernum I figured it myself. Force pushed, hope that's not a problem. 馃槂

@tvernum

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

@elasticmachine Test this please

@ojasgulati

This comment has been minimized.

Copy link
Author

commented May 16, 2019

@tvernum can you help me out why some tests are failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.