Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add conditional and escape quotes to render 'deprecated' macro for Asciidoctor migration #42160

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
2 participants
@jrodewig
Copy link
Contributor

commented May 15, 2019

Adds ifdef conditionals and escape quotes to correctly render an deprecated macro for Asciidoctor. Relates to elastic/docs#827.

Plan to backport to 1.3.

AsciiDoc Before

Before images AsciiDoc - Before A AsciiDoc - Before B

AsciiDoc After

After images AsciiDoc - After A AsciiDoc - After B

Asciidoctor Before

Before images Asciidoctor - Before A Asciidoctor - Before B

Asciidoctor After

After images Asciidoctor - After A Asciidoctor - After B

@jrodewig jrodewig requested a review from nik9000 May 15, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 15, 2019

@jrodewig jrodewig force-pushed the jrodewig:asciidoctor-mapping-core-types branch from ac6b07b to 9bdc248 May 24, 2019

@jrodewig

This comment has been minimized.

Copy link
Contributor Author

commented May 24, 2019

Closing as duplicate of #42236

@jrodewig jrodewig closed this May 24, 2019

@jrodewig jrodewig deleted the jrodewig:asciidoctor-mapping-core-types branch May 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.