Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use translog to estimate number of operations in recovery #42211

Merged
merged 1 commit into from May 21, 2019

Conversation

Projects
None yet
3 participants
@dnhatn
Copy link
Contributor

commented May 20, 2019

Currently, we ignore soft-deletes in peer recovery, thus estimateNumberOfHistoryOperations should always use translog.

Relates #38904

@elasticmachine

This comment has been minimized.

Copy link

commented May 20, 2019

@dnhatn dnhatn requested review from henningandersen and removed request for ywelsch May 20, 2019

@DaveCTurner
Copy link
Contributor

left a comment

LGTM, good catch.

@dnhatn

This comment has been minimized.

Copy link
Contributor Author

commented May 21, 2019

@DaveCTurner Thanks for reviewing.

@dnhatn dnhatn merged commit c1aef4b into elastic:master May 21, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@dnhatn dnhatn deleted the dnhatn:estimate-ops branch May 21, 2019

dnhatn added a commit that referenced this pull request May 22, 2019

Estimate num history ops should always use translog (#42211)
Currently, we ignore soft-deletes in peer recovery, thus
estimateNumberOfHistoryOperations should always use translog.

Relates #38904

gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019

Estimate num history ops should always use translog (elastic#42211)
Currently, we ignore soft-deletes in peer recovery, thus
estimateNumberOfHistoryOperations should always use translog.

Relates elastic#38904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.