Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testclusters: convert ccr tests #42313

Merged
merged 17 commits into from May 29, 2019

Conversation

Projects
None yet
4 participants
@atorok
Copy link
Contributor

commented May 21, 2019

This change converts CCR tests to use testclusters.
This required the ability to configure jvmArgs and a new ESTest task to be able to implement the restart without duplication around configuring systemProperty.

This PR also makes it possible to run with ./gradlew check -Dtestclusters.inspect.failure=true which will pause before stopping the test cluster on a failure to allow inspection.
This is being added in this PR since the restart test failed and this makes it easier to see what's going on. The restart tests are now fixed.

atorok added some commits May 11, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 21, 2019

@elasticmachine

This comment has been minimized.

Copy link

commented May 21, 2019

atorok added some commits May 21, 2019

@jpountz jpountz changed the title Testclsuters: convert ccr tests Testclusters: convert ccr tests May 22, 2019

atorok added some commits May 27, 2019

@mark-vieira
Copy link
Contributor

left a comment

Changes look good 👍

@atorok atorok merged commit 5e0a162 into elastic:master May 29, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@atorok atorok deleted the atorok:testclsuters-x-pack-plugins-ccr branch May 29, 2019

@mark-vieira

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

@atorok I should have caught this in review but it looks like we mistakenly inverted the doNotCacheIf() condition, effectively enabling caching on rest integration tests. I've fixed this, but this needs to be included in the backport if/when that happens.

26a508b

atorok added a commit to atorok/elasticsearch that referenced this pull request Jun 10, 2019

atorok added a commit that referenced this pull request Jun 13, 2019

@jakelandis jakelandis added v7.3.0 and removed v7.2.0 labels Jun 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.