Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JarHellTask cacheable #42551

Merged
merged 1 commit into from May 25, 2019
Merged

Make JarHellTask cacheable #42551

merged 1 commit into from May 25, 2019

Conversation

mark-vieira
Copy link
Contributor

@mark-vieira mark-vieira commented May 25, 2019

Continuing the campaign to make all precommit tasks cacheable. This PR make the JarHellTask cacheable as well as some other improvements. We now use compile classpath normalization here instead of runtime classpath normalization to get some better avoidance benefits since the jar hell detection only cares about what classes are on the classpath, not their implementations. If we cared, we could make this even better, by normalizing out everything but class names and file paths but that's probably overkill.

@mark-vieira mark-vieira added >non-issue :Delivery/Build Build or test infrastructure v8.0.0 labels May 25, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@mark-vieira
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample

@mark-vieira
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/bwc

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mark-vieira mark-vieira merged commit 5ca06a5 into master May 25, 2019
@mark-vieira mark-vieira deleted the cacheable-jar-hell branch May 25, 2019 02:28
mark-vieira added a commit to mark-vieira/elasticsearch that referenced this pull request May 25, 2019
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
mark-vieira added a commit that referenced this pull request May 30, 2019
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure >non-issue Team:Delivery Meta label for Delivery team v7.3.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants