Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable node roles to be pluggable #43175

Merged
merged 12 commits into from Jun 13, 2019

Conversation

Projects
None yet
4 participants
@jasontedor
Copy link
Member

commented Jun 12, 2019

This commit introduces the possibility for a plugin to introduce additional node roles.

Enable node roles to be pluggable
This commit introduces the possibility for a plugin to introduce
additional node roles.
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jun 12, 2019

@jasontedor jasontedor requested a review from jaymode Jun 13, 2019

@rjernst
Copy link
Member

left a comment

Overall looks fine. I have a few requests.

jasontedor added some commits Jun 13, 2019

@jasontedor jasontedor requested a review from rjernst Jun 13, 2019

@jasontedor

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

@rjernst I pushed.

jasontedor added some commits Jun 13, 2019

@rjernst
Copy link
Member

left a comment

LGTM

@jasontedor jasontedor merged commit aa12af8 into elastic:master Jun 13, 2019

9 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

jasontedor added a commit that referenced this pull request Jun 13, 2019

Enable node roles to be pluggable (#43175)
This commit introduces the possibility for a plugin to introduce
additional node roles.

@jasontedor jasontedor deleted the jasontedor:pluggable-roles branch Jun 13, 2019

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 14, 2019

Fix DiscoveryNodeRoleIT
The test fails if querying the roles via a transport client, since the
transport client does not have the plugin necessary to interpret the additional
role correctly. This commit adds this plugin to the transport client used.

Relates elastic#43175
Fixes elastic#43223

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 14, 2019

Add UnknownRole#equals, hashCode, toString
Adds methods to `DiscoveryNodeRole.UnknownRole` to compare these objects'
values for equality, and adds a specialized `toString()` implementation for
clearer test failures.

Relates elastic#43175

DaveCTurner added a commit that referenced this pull request Jun 14, 2019

Fix DiscoveryNodeRoleIT (#43225)
The test fails if querying the roles via a transport client, since the
transport client does not have the plugin necessary to interpret the additional
role correctly. This commit adds this plugin to the transport client used.

Relates #43175
Fixes #43223

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 15, 2019

Make DiscoveryNodeRole into a value object
Adds `equals()` and `hashcode()` methods to `DiscoveryNodeRole` to compare
these objects' values for equality, and adds a field to allow us to distinguish
unknown roles from known ones with the same name and abbreviation, for clearer
test failures.

Relates elastic#43175

pull bot pushed a commit to rogues-gallery/elasticsearch that referenced this pull request Jun 17, 2019

Make DiscoveryNodeRole into a value object (elastic#43257)
Adds `equals()` and `hashcode()` methods to `DiscoveryNodeRole` to compare
these objects' values for equality, and adds a field to allow us to distinguish
unknown roles from known ones with the same name and abbreviation, for clearer
test failures.

Relates elastic#43175

DaveCTurner added a commit that referenced this pull request Jun 17, 2019

Make DiscoveryNodeRole into a value object (#43257)
Adds `equals()` and `hashcode()` methods to `DiscoveryNodeRole` to compare
these objects' values for equality, and adds a field to allow us to distinguish
unknown roles from known ones with the same name and abbreviation, for clearer
test failures.

Relates #43175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.