Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Increase hard limit for sorting on aggregates #43220

Merged
merged 2 commits into from Jun 14, 2019

Conversation

@matriv
Copy link
Contributor

commented Jun 13, 2019

To be consistent with the search.max_buckets default setting,
set the hard limit of the PriorityQueue used for in memory sorting,
when sorting on an aggregate function, to 10000.

Fixes: #43168

To be consistent with the `search.max_buckets` default setting,
set the hard limit of the PriorityQueue used for in memory sorting,
when sorting on an aggregate function, to 10000.

Fixes: #43168
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

@matriv

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

I'm not sure if this should be an enhancement, or a non-issue and also backport it to prev versions.
@astefan @jimczi What do you think?

@matriv

This comment has been minimized.

Copy link
Contributor Author

commented Jun 13, 2019

@elasticmachine run elasticsearch-ci/1

Copy link
Contributor

left a comment

LGTM

@astefan

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

Imo, it should go into all acceptable versions. This functionality was introduced in 6.7.0 and 7.0.0-beta1 and I don't why the limit increase shouldn't be applied to 6.8, 7.1, 7.2, 7.x and 8.

@jimczi
jimczi approved these changes Jun 14, 2019
Copy link
Member

left a comment

LGTM too

@matriv matriv added v6.8.1 v7.2.0 >bug and removed >enhancement labels Jun 14, 2019
@matriv matriv merged commit 079e012 into elastic:master Jun 14, 2019
8 checks passed
8 checks passed
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/docs-check Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
@matriv matriv deleted the matriv:fix-43168 branch Jun 14, 2019
matriv added a commit that referenced this pull request Jun 14, 2019
To be consistent with the `search.max_buckets` default setting,
set the hard limit of the PriorityQueue used for in memory sorting,
when sorting on an aggregate function, to 10000.

Fixes: #43168

(cherry picked from commit 079e012)
@jakelandis jakelandis added v6.8.2 and removed v7.2.0 v6.8.1 labels Jun 17, 2019
@matriv matriv added the v7.2.1 label Jun 24, 2019
matriv added a commit that referenced this pull request Jun 24, 2019
To be consistent with the `search.max_buckets` default setting,
set the hard limit of the PriorityQueue used for in memory sorting,
when sorting on an aggregate function, to 10000.

Fixes: #43168

(cherry picked from commit 079e012)
(cherry picked from commit 9cd89c3)
matriv added a commit that referenced this pull request Jun 26, 2019
To be consistent with the `search.max_buckets` default setting,
set the hard limit of the PriorityQueue used for in memory sorting,
when sorting on an aggregate function, to 10000.

Fixes: #43168

(cherry picked from commit 079e012)
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Jun 27, 2019
To be consistent with the `search.max_buckets` default setting,
set the hard limit of the PriorityQueue used for in memory sorting,
when sorting on an aggregate function, to 10000.

Fixes: elastic#43168
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.