Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent NullPointerException in TransportRolloverAction #43353

Merged
merged 1 commit into from Jun 19, 2019

Conversation

@dakrone
Copy link
Member

commented Jun 18, 2019

It's possible for the passed in IndexMetaData to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a NullPointerException when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves #43296

It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves #43296
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

Copy link
Member

left a comment

LGTM

I don't think we need to backport top the 7.0 branch? That version line is no longer maintained.
Does this problem also exist in 6.8.0? If so then I think we should also backport to the 6.x branch.

Copy link
Contributor

left a comment

Thanks @dakrone. I left a question.

@dakrone dakrone added v6.8.2 and removed v7.0.2 labels Jun 19, 2019
@dnhatn
dnhatn approved these changes Jun 19, 2019
Copy link
Contributor

left a comment

LGTM

@dakrone dakrone merged commit 4b1c133 into elastic:master Jun 19, 2019
8 checks passed
8 checks passed
CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jun 19, 2019
It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves elastic#43296
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Jun 19, 2019
It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves elastic#43296
@dakrone dakrone deleted the dakrone:fix-rollover-npe branch Jun 19, 2019
dakrone added a commit that referenced this pull request Jun 19, 2019
#43397)

It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves #43296
dakrone added a commit that referenced this pull request Jun 19, 2019
#43398)

It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves #43296
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Jun 27, 2019
It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves elastic#43296
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Aug 23, 2019
It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves elastic#43296
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Aug 23, 2019
It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves elastic#43296
@dakrone dakrone added the v6.8.3 label Aug 23, 2019
dakrone added a commit that referenced this pull request Aug 23, 2019
)

It's possible for the passed in `IndexMetaData` to be null (for
instance, cluster state passed in does not have the index in its
metadata) which in turn can cause a `NullPointerException` when
evaluating the conditions for an index. This commit adds null protection
and unit tests for this case.

Resolves #43296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.