Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Removes out-dated info from Watcher limitations #44252

Merged
merged 1 commit into from Jul 17, 2019

Conversation

Projects
None yet
5 participants
@lcawl
Copy link
Contributor

commented Jul 12, 2019

This PR removes the following Watcher limitation from the documentation:

https://www.elastic.co/guide/en/elastic-stack-overview/master/watcher-limitations.html#_watcher_ui

There is no longer a "Save" button so this work-around no longer applies.

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jul 12, 2019

@lcawl lcawl requested a review from jakelandis Jul 12, 2019

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

The save button is still there, it is just called Create watch or Save watch and moved.

image

edit:

image

However, with out any history or context, this seems like an odd thing to call out in the first place.

I am +1 to accept this change as-is or +1 to update the image.

cc @elastic/es-ui

@alisonelizabeth

This comment has been minimized.

Copy link

commented Jul 17, 2019

++ to @jakelandis's comment.

FWIW I think this would apply to many of our apps, not just watcher, so it seems strange that we were only calling it out for watcher.

@cjcenizal

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

I think we had good intentions when we originally added this documentation but I agree that it's incongruous with the rest of our content and removing it is for the best.

@jakelandis

This comment has been minimized.

Copy link
Contributor

commented Jul 17, 2019

thanks @alisonelizabeth @cjcenizal

LGTM as-is to remove it (but may want to tweak the commit message).

@lcawl lcawl changed the title [DOCS] Removes out-dated Watcher limitation [DOCS] Removes out-dated info from Watcher limitations Jul 17, 2019

@lcawl lcawl merged commit 6e96ba7 into elastic:master Jul 17, 2019

8 checks passed

CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details

@lcawl lcawl deleted the lcawl:watcher-limitations branch Jul 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.