Fix BulkProcessor hangs for threads deadlocked (#44556) #44559
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-features |
|
hi @suxinglee thanks for opening this PR! Would it be possible to add a test that recreates the scenario of the issue you have encountered, which fails without your fix and succeeds once you made your changes? |
|
@suxinglee - could you please review the latest comment ? |
|
do we have any updates on this issue and what's the case this issue reproduced? thanks |
|
@jakelandis due to the modified of base branch, I close the current PR and open another PR #46790 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #44556 bulk processor threads gets deadlocked, and Java application using BulkProcessing hangs without any data flush. This problem have been discussed in two issues. One way to solve this deadlock is add a single ScheduledThreadPoolExecutor instance for
FlushTask.