[ML-DataFrame] fix starting a batch data frame after stopping at runtime #45340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…opped/ started within one run
|
Pinging @elastic/ml-core |
hendrikmuhs
commented
Aug 8, 2019
| * @return checkpoint in progress or 0 if task/indexer is not active | ||
| */ | ||
| public long getInProgressCheckpoint() { | ||
| return indexerState.equals(IndexerState.INDEXING) ? checkpoint + 1L : 0; |
There was a problem hiding this comment.
gone for good, next checkpoint is not dependent on the indexer state.
| @@ -200,9 +204,9 @@ protected void nodeOperation(AllocatedPersistentTask task, @Nullable DataFrameTr | |||
| final long lastCheckpoint = stateHolder.get().getCheckpoint(); | |||
|
|
|||
| if (lastCheckpoint == 0) { | |||
| logger.trace("[{}] No checkpoint found, starting the task", transformId); | |||
| startTask(buildTask, indexerBuilder, lastCheckpoint, startTaskListener); | |||
There was a problem hiding this comment.
this is the main fix: we started the task without loading the next checkpoint when last checkpoint is 0,
|
|
||
| if (nextCheckpoint.isEmpty()) { | ||
| // corner case which should not happen ;-) | ||
| // reset the position to force a full re-run with checkpoint creation |
There was a problem hiding this comment.
getTransformCheckpoint always returns a checkpoint object: in case it does not find a document in the internal index, it returns an empty object.
added 2 commits
August 8, 2019 17:18
benwtrent
approved these changes
Aug 8, 2019
.../org/elasticsearch/xpack/dataframe/transforms/DataFrameTransformPersistentTasksExecutor.java
Outdated
Show resolved
Hide resolved
.../org/elasticsearch/xpack/dataframe/transforms/DataFrameTransformPersistentTasksExecutor.java
Outdated
Show resolved
Hide resolved
…/dataframe/transforms/DataFrameTransformPersistentTasksExecutor.java Co-Authored-By: Benjamin Trent <ben.w.trent@gmail.com>
|
run elasticsearch-ci/1 |
1 similar comment
|
run elasticsearch-ci/1 |
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Aug 9, 2019
…ime (elastic#45340) fix loading of next checkpoint after data frame transform has been stopped/started within one run closes elastic#45339
hendrikmuhs
pushed a commit
to hendrikmuhs/elasticsearch
that referenced
this pull request
Aug 9, 2019
…ime (elastic#45340) fix loading of next checkpoint after data frame transform has been stopped/started within one run closes elastic#45339
This was referenced Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix loading of next checkpoint after data frame transform has been stopped/started within one run
closes #45339
The logic introduced in #44219 wrongly assumed no next checkpoint if no checkpoint has not been created yet. The fix properly loads the next checkpoint.