Audit log filter and marker #45456
Merged
Audit log filter and marker #45456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertzaharovits
added
>non-issue
:Security/Audit
|
Pinging @elastic/es-security |
|
@elasticmachine run elasticsearch-ci/2 |
tvernum
reviewed
Oct 7, 2019
| @@ -151,6 +158,8 @@ | |||
| "indices", | |||
| (key) -> Setting.listSetting(key, Collections.singletonList("*"), Function.identity(), Property.NodeScope, Property.Dynamic)); | |||
|
|
|||
| private static final Marker AUDIT_MARKER = MarkerManager.getMarker("AUDIT"); | |||
There was a problem hiding this comment.
Can we prefix this with ES_? I hope none of our dependencies are using Marker objects, but if they are we want to be extra sure that we don't get name conflicts.
There was a problem hiding this comment.
Good point! I have renamed the marker to org.elasticsearch.xpack.security.audit .
Please take another look.
tvernum
approved these changes
Nov 13, 2019
|
@elasticmachine update branch |
This was referenced Nov 15, 2019
albertzaharovits
added a commit
that referenced
this pull request
Nov 15, 2019
This adds a log marker and a marker filter for the audit log. Closes #47251
albertzaharovits
added a commit
that referenced
this pull request
Nov 15, 2019
This adds a log marker and a marker filter for the audit log. Closes #47251
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a log marker and a marker filter for the audit log.
Closes #47251